Deny unreachable_pub

Author: clarfonthey

Cargo.toml

@@ -14,6 +14,7 @@ rust-version = "1.84.0"
 
 [lints.rust]
 missing_docs = "warn"
+unreachable_pub = "warn"
 unsafe_op_in_unsafe_fn = "warn"
 
 # rust_2018_idioms

src/raw/alloc.rs

@@ -9,7 +9,7 @@ pub(crate) use self::inner::{do_alloc, Allocator, Global};
 #[cfg(feature = "nightly")]
 mod inner {
     #[cfg(test)]
-    pub use crate::alloc::alloc::AllocError;
+    pub(crate) use crate::alloc::alloc::AllocError;
     use crate::alloc::alloc::Layout;
     pub(crate) use crate::alloc::alloc::{Allocator, Global};
     use core::ptr::NonNull;

src/raw/mod.rs

@@ -242,7 +242,7 @@ impl TableLayout {
 /// This is usually just a pointer to the element itself. However if the element
 /// is a ZST, then we instead track the index of the element in the table so
 /// that `erase` works properly.
-pub struct Bucket<T> {
+pub(crate) struct Bucket<T> {
     // Actually it is pointer to next element than element itself
     // this is needed to maintain pointer arithmetic invariants
     // keeping direct pointer to element introduces difficulty.