Fix: Prevent 'argument list too long' error in hooks#167
Merged
Conversation
Set the IFS variable to a newline in base-template.sh. This prevents the 'argument list too long' error when hook scripts iterate over the STAGED_FILES environment variable with a large number of files. This change is made in the central `base-template.sh` script to avoid modifying numerous hook scripts, and to be robust for future hook scripts.
Pull Request Test Coverage Report for Build 16791154733Details
💛 - Coveralls |
I've set the IFS variable to a newline in base-template.sh. This will prevent the 'argument list too long' error when hook scripts iterate over the STAGED_FILES environment variable with a large number of files. I made this change in the central `base-template.sh` script to avoid modifying numerous hook scripts, and to be robust for future hook scripts. I've also added a new test case (tests/step-101.sh) to verify the fix by committing a large number of files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an 'argument list too long' error that can occur when processing a large number of files in the git hooks. The fix involves setting the
IFSvariable to a newline inbase-template.sh, which ensures that hook scripts can safely iterate over the list of staged files.