Modern implementation of this formula

[johnkeates]

I made a more modern implementation of this formula at https://github.com/johnkeates/filebeat-formula it might be worth rebasing this one on top of that.

[gravyboat]

Can you prep a PR so we can compare the diff?

[johnkeates]

Sure thing, I'll fiddle with the GitHub interface a bit, hold on a sec.

[gravyboat]

Sounds good. I probably won't be able to review it since I'm not familiar with filebeat and what an 'improved' version would look like past enhanced Salt functionality, but we can see if @cybacolt is willing to take a look.

[johnkeates]

It's basically improved by means of not duplicating every bloody key/value thing from the Salt yaml to JINJA and back to yaml for Filebeat, and it's using standard repositories and standard service management to run the thing instead of a convoluted SSH localhost setup ;-) I'm not sure how to create a PR from a non-forked repo at the moment.

[johnkeates]

So I decided I didn't care that much, so I just forked, removed everything, put in the files from my repo and commit & PR the thing. #10

[gravyboat]

Thanks, I've commented over there and tagged this.

[cybacolt]

i've added comments in the PR. some good stuff, but also some concerns.

this will break existing configs, and remove some functionality.

apologies for not getting to this earlier!