From f2c9652bb5d4da12ccbf3c418f712230b469bfc5 Mon Sep 17 00:00:00 2001 From: Peter Dannemann Date: Thu, 6 Mar 2025 11:41:37 -0500 Subject: [PATCH 1/2] fix: add sasl-secrets-manager-arn to shared opts --- cmd/topicctl/subcmd/shared.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cmd/topicctl/subcmd/shared.go b/cmd/topicctl/subcmd/shared.go index 60144a70..41f6184e 100644 --- a/cmd/topicctl/subcmd/shared.go +++ b/cmd/topicctl/subcmd/shared.go @@ -314,4 +314,10 @@ func addSharedConfigOnlyFlags(cmd *cobra.Command, options *sharedOptions) { os.Getenv("TOPICCTL_SASL_USERNAME"), "SASL username if using SASL; will override value set in cluster config", ) + cmd.PersistentFlags().StringVar( + &options.saslSecretsManagerArn, + "sasl-secrets-manager-arn", + os.Getenv("TOPICCTL_SASL_SECRETS_MANAGER_ARN"), + "Secrets Manager ARN to use for credentials if using SASL; will override value set in cluster config", + ) } From 1c8153dad2636c8bfbb45b6c0f2eb78dd2b7f87c Mon Sep 17 00:00:00 2001 From: Peter Dannemann Date: Thu, 6 Mar 2025 11:42:24 -0500 Subject: [PATCH 2/2] persistentflags -> flags --- cmd/topicctl/subcmd/shared.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/topicctl/subcmd/shared.go b/cmd/topicctl/subcmd/shared.go index 41f6184e..ba056165 100644 --- a/cmd/topicctl/subcmd/shared.go +++ b/cmd/topicctl/subcmd/shared.go @@ -314,7 +314,7 @@ func addSharedConfigOnlyFlags(cmd *cobra.Command, options *sharedOptions) { os.Getenv("TOPICCTL_SASL_USERNAME"), "SASL username if using SASL; will override value set in cluster config", ) - cmd.PersistentFlags().StringVar( + cmd.Flags().StringVar( &options.saslSecretsManagerArn, "sasl-secrets-manager-arn", os.Getenv("TOPICCTL_SASL_SECRETS_MANAGER_ARN"),