fix: Editorial review PR comment acknowledgment failing#1115
Open
justinegeffen wants to merge 1 commit intomasterfrom
Open
fix: Editorial review PR comment acknowledgment failing#1115justinegeffen wants to merge 1 commit intomasterfrom
justinegeffen wants to merge 1 commit intomasterfrom
Conversation
The acknowledge command was failing with "fatal: not a git repository" because gh CLI requires either a checkout or explicit --repo flag. Fixes /editorial-review PR comment trigger failing on acknowledgment step. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
justinegeffen
added
1. Dev/PM/SME
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the /editorial-review PR comment trigger workflow where the acknowledgment step was failing with "fatal: not a git repository" error. The fix adds the --repo flag to the gh pr comment command in the check-trigger job, allowing it to work without a repository checkout.
Changes:
- Added
--repo ${{ github.repository }}flag togh pr commentcommand in the acknowledgment step
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/editorial-reviewcommand in PR comments was triggering the workflow but failing on the acknowledgment step with:Root cause
The
check-triggerjob runsgh pr commentwithout:actions/checkout@v4)--repoflagThe
ghCLI needs one of these to work.Solution
Added
--repo ${{ github.repository }}flag to thegh pr commentcommand.This is the minimal fix - no checkout needed since we're only posting a comment via GitHub API.
Testing
After merge, comment
/editorial-reviewon any PR - should see:✅ "🔍 Editorial review started! View workflow run" comment posted immediately
Related
/editorial-reviewPR comment trigger functionality