Bug about setting a globalbox

[chenhanpolyu]

First I would like to thank you for your code and it has been used in my project, showing very impressive performance in computing efficiency and convenience. However, when recently I want to try to limit the spatial range of the Polyhedrons, I found the globalbox function offered by your code may has a BUG:https://github.com/sikang/DecompUtil/blame/b0836c7228d19f0fa97282c584b55adf642279da/include/decomp_util/ellipsoid_decomp.h#:~:text=Vs.add(Hyperplane3D(Vec3f(0%2C%20global_bbox_max_(1)%2C%200)%2C%20Vec3f(0%2C%20-1%2C%200)))%3B
I think this line should be Vs.add(Plane3D(Vec3f(0, global_bbox_min_(1), 0), Vec3f(0, -1, 0)));. Right? Or it will generate too many polyhedra than expected.

[ZYS98]

Did you publish your project in Github @chenhanpolyu ? I'm trying to implement the convex decomposition in Python/Matlab in 2D, but I am running into some problems.

[liangbingning]

您是否在 Github 上发布了您的项目？我正在尝试在 Python/Matlab 中以 2D 形式实现凸分解，但我遇到了一些问题。

Have you done zhe job?

[HauserDong]

First I would like to thank you for your code and it has been used in my project, showing very impressive performance in computing efficiency and convenience. However, when recently I want to try to limit the spatial range of the Polyhedrons, I found the globalbox function offered by your code may has a BUG:https://github.com/sikang/DecompUtil/blame/b0836c7228d19f0fa97282c584b55adf642279da/include/decomp_util/ellipsoid_decomp.h#:~:text=Vs.add(Hyperplane3D(Vec3f(0%2C%20global_bbox_max_(1)%2C%200)%2C%20Vec3f(0%2C%20-1%2C%200)))%3B I think this line should be Vs.add(Plane3D(Vec3f(0, global_bbox_min_(1), 0), Vec3f(0, -1, 0)));. Right? Or it will generate too many polyhedra than expected.

God! I spent nearly a whole day and finally find this bug out.
hope I see your post earlier