Skip to content

Remove name from SummonerDto #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgrinspan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove name from SummonerDto #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/Riot/DTO/SummonerDTO.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ final class SummonerDTO implements DTOInterface

private int $revisionDate;

private string $name;

private string $id;

private string $puuid;
Expand All @@ -24,15 +22,13 @@ public function __construct(
string $accountId,
int $profileIconId,
int $revisionDate,
string $name,
string $id,
string $puuid,
int $summonerLevel
) {
$this->accountId = $accountId;
$this->profileIconId = $profileIconId;
$this->revisionDate = $revisionDate;
$this->name = $name;
$this->id = $id;
$this->puuid = $puuid;
$this->summonerLevel = $summonerLevel;
Expand All @@ -53,11 +49,6 @@ public function getRevisionDate(): int
return $this->revisionDate;
}

public function getName(): string
{
return $this->name;
}

public function getId(): string
{
return $this->id;
Expand All @@ -82,7 +73,6 @@ public static function createFromArray(array $data): SummonerDTO
$data['accountId'],
$data['profileIconId'],
$data['revisionDate'],
$data['name'],
$data['id'],
$data['puuid'],
$data['summonerLevel'],
Expand Down