dx12::PlatformStructuredBuffer::AsD3D12ShaderResourceView() transition is for all shader stages.

AndrewRichards-Code · AndrewRichards-Code · commit d626dc01b8a6 · 2025-01-30T15:54:40.000Z
diff --git a/DirectX12/PlatformStructuredBuffer.cpp b/DirectX12/PlatformStructuredBuffer.cpp
@@ -397,7 +397,7 @@ D3D12_CPU_DESCRIPTOR_HANDLE* PlatformStructuredBuffer::AsD3D12ShaderResourceView
 	
 	// Check the resource state
 	bool is_pixel_shader=(deviceContext.contextState.currentEffectPass->shaders[crossplatform::SHADERTYPE_PIXEL]!=nullptr);
-	 D3D12_RESOURCE_STATES		readState = is_pixel_shader?D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE:D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE;
+	D3D12_RESOURCE_STATES readState = is_pixel_shader ? D3D12_RESOURCE_STATE_ALL_SHADER_RESOURCE : D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE;
 	if (mCurrentState != readState)
 	{
 		mRenderPlatform->ResourceTransitionSimple(deviceContext,mGPUBuffer, mCurrentState, readState);

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ D3D12_CPU_DESCRIPTOR_HANDLE* PlatformStructuredBuffer::AsD3D12ShaderResourceView`
`397`	`397`
`398`	`398`	`// Check the resource state`
`399`	`399`	`bool is_pixel_shader=(deviceContext.contextState.currentEffectPass->shaders[crossplatform::SHADERTYPE_PIXEL]!=nullptr);`
`400`		`- D3D12_RESOURCE_STATES readState = is_pixel_shader?D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE:D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE;`
	`400`	`+ D3D12_RESOURCE_STATES readState = is_pixel_shader ? D3D12_RESOURCE_STATE_ALL_SHADER_RESOURCE : D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE;`
`401`	`401`	`if (mCurrentState != readState)`
`402`	`402`	`{`
`403`	`403`	`mRenderPlatform->ResourceTransitionSimple(deviceContext,mGPUBuffer, mCurrentState, readState);`