From 4c086b1709057cf829a9de643309c394d0d75160 Mon Sep 17 00:00:00 2001 From: Will Winder Date: Mon, 26 Jan 2026 13:38:59 -0500 Subject: [PATCH 1/5] Call cov script outside of the block comment. --- .github/workflows/test-coverage-report.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-coverage-report.yaml b/.github/workflows/test-coverage-report.yaml index 7cdc4b1c5..a16b2d5a6 100644 --- a/.github/workflows/test-coverage-report.yaml +++ b/.github/workflows/test-coverage-report.yaml @@ -57,9 +57,11 @@ jobs: just test-coverage coverage_target.out short # switch back to the head ref git checkout ${{ github.head_ref }} + ./tools/bin/cov_compare.sh --no-header coverage_target.out coverage.out > table + echo table { echo 'coverage_report<> "$GITHUB_ENV" - name: Remove previous coverage comments From 9505772379548f0517b6aeac3af664c4b503daae Mon Sep 17 00:00:00 2001 From: Will Winder Date: Mon, 26 Jan 2026 14:07:37 -0500 Subject: [PATCH 2/5] debugging --- .github/workflows/test-coverage-report.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test-coverage-report.yaml b/.github/workflows/test-coverage-report.yaml index a16b2d5a6..ac84a3f21 100644 --- a/.github/workflows/test-coverage-report.yaml +++ b/.github/workflows/test-coverage-report.yaml @@ -57,7 +57,9 @@ jobs: just test-coverage coverage_target.out short # switch back to the head ref git checkout ${{ github.head_ref }} + set -x ./tools/bin/cov_compare.sh --no-header coverage_target.out coverage.out > table + echo "Table:" echo table { echo 'coverage_report< Date: Mon, 26 Jan 2026 14:17:36 -0500 Subject: [PATCH 3/5] Fix cov_compare.sh --- tools/bin/cov_compare.sh | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/bin/cov_compare.sh b/tools/bin/cov_compare.sh index 2aad6d2f6..842f6b355 100755 --- a/tools/bin/cov_compare.sh +++ b/tools/bin/cov_compare.sh @@ -8,7 +8,10 @@ # ./cov_compare.sh --no-header coverage.out coverage_new.out NO_HEADER=0 -ARGS="" + +# Collect non-flag arguments in an array so they remain separate when +# resetting positional parameters with `set --`. +ARGS=() # Parse optional flags for arg in "$@"; do @@ -17,13 +20,13 @@ for arg in "$@"; do NO_HEADER=1 ;; *) - ARGS="$ARGS $arg" + ARGS+=("$arg") ;; esac done # Reset positional parameters -set -- "$ARGS" +set -- "${ARGS[@]}" if [ "$#" -ne 2 ]; then echo "Usage: $0 [--no-header] coverage1.out coverage2.out" >&2 From 8bca7aeac06a96a38d33667c0b5039cb029e0322 Mon Sep 17 00:00:00 2001 From: Will Winder Date: Mon, 26 Jan 2026 14:26:47 -0500 Subject: [PATCH 4/5] Remove debug output. --- .github/workflows/test-coverage-report.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test-coverage-report.yaml b/.github/workflows/test-coverage-report.yaml index ac84a3f21..af049a340 100644 --- a/.github/workflows/test-coverage-report.yaml +++ b/.github/workflows/test-coverage-report.yaml @@ -58,12 +58,10 @@ jobs: # switch back to the head ref git checkout ${{ github.head_ref }} set -x - ./tools/bin/cov_compare.sh --no-header coverage_target.out coverage.out > table - echo "Table:" - echo table + ./tools/bin/cov_compare.sh --no-header coverage_target.out coverage.out > table.txt { echo 'coverage_report<> "$GITHUB_ENV" - name: Remove previous coverage comments From c404fbc964386aeff81a6b6f45646d79ad121983 Mon Sep 17 00:00:00 2001 From: Will Winder Date: Mon, 26 Jan 2026 14:27:29 -0500 Subject: [PATCH 5/5] Cleanup. --- .github/workflows/test-coverage-report.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-coverage-report.yaml b/.github/workflows/test-coverage-report.yaml index af049a340..cebf7828c 100644 --- a/.github/workflows/test-coverage-report.yaml +++ b/.github/workflows/test-coverage-report.yaml @@ -57,8 +57,8 @@ jobs: just test-coverage coverage_target.out short # switch back to the head ref git checkout ${{ github.head_ref }} - set -x ./tools/bin/cov_compare.sh --no-header coverage_target.out coverage.out > table.txt + cat table.txt { echo 'coverage_report<