Merge pull request #2 from alexlafroscia/better-runloop-integration

Better runloop integration

Author: smashweaver

addon/initializers/nprogress.js

@@ -0,0 +1,15 @@
+import Ember from 'ember';
+import nprogress from 'ember-cli-nprogress';
+
+const { run } = Ember;
+
+export const scheduler = run.later.bind(undefined, undefined);
+
+export function initialize() {
+  nprogress.configure({ scheduler });
+}
+
+export default {
+  name: 'nprogress',
+  initialize
+};

app/initializers/nprogress.js

@@ -0,0 +1 @@
+export { default, initialize } from 'ember-cli-nprogress/initializers/nprogress';

blueprints/ember-cli-nprogress/index.js

@@ -2,6 +2,6 @@ module.exports = {
   normalizeEntityName: function() {}, // no-op since we're just adding dependencies
 
   afterInstall: function() {
-    return this.addBowerPackageToProject('nprogress', '^0.2.0');
+    return this.addBowerPackageToProject('nprogress', 'alexlafroscia/nprogress#allow-alternate-scheduler');
   }
 };

bower.json

@@ -3,6 +3,6 @@
   "dependencies": {
     "ember": "~2.10.0",
     "ember-cli-shims": "0.1.3",
-    "nprogress": "^0.2.0"
+    "nprogress": "alexlafroscia/nprogress#allow-alternate-scheduler"
   }
 }

tests/acceptance/run-loop-test.js

@@ -0,0 +1,33 @@
+import { test } from 'qunit';
+import moduleForAcceptance from '../../tests/helpers/module-for-acceptance';
+
+import nprogress from 'ember-cli-nprogress';
+
+// Note: This somewhat unorthidox test setup will throw an error when running the tests in Chrome,
+// if `nprogress` isn't configured to run within the Ember run loop
+moduleForAcceptance('Acceptance | run loop', {
+  beforeEach() {
+    nprogress.configure({
+      parent: '#nprogress-parent'
+    });
+  }
+});
+
+// This is required to get the app set up
+test('loading an initial route', function(assert) {
+  assert.expect(0);
+
+  visit('/');
+});
+
+// This test just verifies that an error is not produced in cases where `nprogress`
+// is running while the app is being torn down
+test('it fires the `start` event within the run loop', function(assert) {
+  visit('/');
+
+  click('a');
+
+  andThen(function() {
+    assert.equal(currentURL(), '/some-other-route');
+  });
+});

tests/dummy/app/router.js

@@ -7,6 +7,7 @@ const Router = Ember.Router.extend({
 });
 
 Router.map(function() {
+  this.route('some-other-route');
 });
 
 export default Router;

tests/dummy/app/routes/application.js

@@ -0,0 +1,16 @@
+import Ember from 'ember';
+import nprogress from 'ember-cli-nprogress';
+
+const { Route } = Ember;
+
+export default Route.extend({
+  actions: {
+    willTransition() {
+      nprogress.start();
+    },
+
+    didTransition() {
+      nprogress.done();
+    }
+  }
+});

tests/dummy/app/templates/application.hbs

@@ -1,3 +1,3 @@
-<h2 id="title">Welcome to Ember</h2>
+<div id='nprogress-parent'></div>
 
 {{outlet}}

tests/dummy/app/templates/index.hbs

@@ -0,0 +1,3 @@
+<h1>Hello, world!</h1>
+
+{{link-to 'Some other route' 'some-other-route'}}

tests/dummy/app/templates/some-other-route.hbs

@@ -0,0 +1,2 @@
+<h1>Some Other Route</h1>
+