Skip to content

Commit f41484e

Browse files
committed
1 parent aa5de07 commit f41484e

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

src/java/org/snapbackup/utilities/ZipEngine.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,6 @@ void logSkippedMsg(String msg) {
123123
}
124124

125125
public void zipFile(String filePath) {
126-
if (zipCount % 500 == 0) //attempt to address performance issues on large backups
127-
rt.gc(); //testing not yet done to see if this improves performance
128126
try {
129127
file = new File(filePath);
130128
String filename = file.getName();

tools/static-analysis/report.html

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -514,13 +514,7 @@
514514
<tr>
515515
<td align="center">8</td>
516516
<td width="*%">snapbackup/src/java/org/snapbackup/utilities/ZipEngine.java</td>
517-
<td align="center" width="5%">127</td>
518-
<td width="*"><a href="https://docs.pmd-code.org/pmd-doc-7.8.0/pmd_rules_java_errorprone.html#donotcallgarbagecollectionexplicitly">Do not explicitly trigger a garbage collection.</a></td>
519-
</tr>
520-
<tr bgcolor="lightgrey">
521-
<td align="center">9</td>
522-
<td width="*%">snapbackup/src/java/org/snapbackup/utilities/ZipEngine.java</td>
523-
<td align="center" width="5%">145</td>
517+
<td align="center" width="5%">143</td>
524518
<td width="*"><a href="https://docs.pmd-code.org/pmd-doc-7.8.0/pmd_rules_java_errorprone.html#closeresource">Ensure that resources like this BufferedInputStream object are closed after use</a></td>
525519
</tr>
526520
</table></body></html>

0 commit comments

Comments
 (0)