From 5a2e39c9dafbe83d9bdcead7620841660f78964e Mon Sep 17 00:00:00 2001 From: soblin Date: Wed, 14 Jan 2026 18:51:36 +0900 Subject: [PATCH] refactor(ansible): declare become only when false Signed-off-by: soblin --- ansible/roles/dev_tools/tasks/commands/difft.yaml | 2 -- ansible/roles/dev_tools/tasks/commands/docker.yaml | 1 - ansible/roles/dev_tools/tasks/commands/emacs.yaml | 4 ++++ ansible/roles/dev_tools/tasks/commands/fish.yaml | 2 ++ ansible/roles/dev_tools/tasks/commands/gh.yaml | 1 - ansible/roles/init_snap/tasks/main.yaml | 1 - ansible/roles/system_tools/tasks/commands/tmux.yaml | 4 ++++ ansible/roles/xdg_base_directory/tasks/main.yaml | 2 ++ 8 files changed, 12 insertions(+), 5 deletions(-) diff --git a/ansible/roles/dev_tools/tasks/commands/difft.yaml b/ansible/roles/dev_tools/tasks/commands/difft.yaml index 76ede91..2b45fce 100644 --- a/ansible/roles/dev_tools/tasks/commands/difft.yaml +++ b/ansible/roles/dev_tools/tasks/commands/difft.yaml @@ -8,7 +8,6 @@ dest: /tmp/difftastic.tar.gz - name: install difftastic - become: false ansible.builtin.unarchive: src: /tmp/difftastic.tar.gz # NOTE: only contains "difft" file @@ -16,4 +15,3 @@ - name: check difft ansible.builtin.command: which difft - changed_when: false diff --git a/ansible/roles/dev_tools/tasks/commands/docker.yaml b/ansible/roles/dev_tools/tasks/commands/docker.yaml index 6e296fe..28101b2 100644 --- a/ansible/roles/dev_tools/tasks/commands/docker.yaml +++ b/ansible/roles/dev_tools/tasks/commands/docker.yaml @@ -1,5 +1,4 @@ - name: setup docker - become: true block: # apt - block: diff --git a/ansible/roles/dev_tools/tasks/commands/emacs.yaml b/ansible/roles/dev_tools/tasks/commands/emacs.yaml index 9abbfc0..4a1a30e 100644 --- a/ansible/roles/dev_tools/tasks/commands/emacs.yaml +++ b/ansible/roles/dev_tools/tasks/commands/emacs.yaml @@ -16,11 +16,13 @@ # file is backed-up, but existing symlink is kept - name: backup .emacs if already exists + become: false ansible.builtin.shell: >- mv "{{ lookup('env', 'HOME') }}/.emacs" "{{ lookup('env', 'HOME') }}/.emacs.bak" when: dot_emacs_exists.stat.exists and not dot_emacs_exists.stat.islnk - name: create symlink to .emacs(unless symlink does not already exist) + become: false file: src: "{{ (playbook_dir + '/../.emacs') | realpath }}" dest: "{{ lookup('env', 'HOME') }}/.emacs" @@ -34,11 +36,13 @@ changed_when: false - name: backup .emacs.d if already exists + become: false ansible.builtin.shell: >- mv "{{ lookup('env', 'HOME') }}/.emacs.d" "{{ lookup('env', 'HOME') }}/.emacs.d.bak" when: dot_emacs_d_exists.stat.exists and not dot_emacs_d_exists.stat.islnk - name: create symlink to .emacs.d(unless symlink does not already exist) + become: false file: src: "{{ (playbook_dir + '/../.emacs.d') | realpath }}" dest: "{{ lookup('env', 'HOME') }}/.emacs.d" diff --git a/ansible/roles/dev_tools/tasks/commands/fish.yaml b/ansible/roles/dev_tools/tasks/commands/fish.yaml index d9420e2..4ad35fd 100644 --- a/ansible/roles/dev_tools/tasks/commands/fish.yaml +++ b/ansible/roles/dev_tools/tasks/commands/fish.yaml @@ -19,11 +19,13 @@ changed_when: false - name: backup .config/fish if already exists + become: false ansible.builtin.shell: >- mv "{{ lookup('env', 'HOME') }}/.config/fish" "{{ lookup('env', 'HOME') }}/.config/fish.bak" when: fish_config_exists.stat.exists and not fish_config_exists.stat.islnk - name: create symlink to .config/fish(unless symlink does not already exist) + become: false file: src: "{{ (playbook_dir + '/../.config/fish') | realpath }}" dest: "{{ lookup('env', 'HOME') }}/.config/fish" diff --git a/ansible/roles/dev_tools/tasks/commands/gh.yaml b/ansible/roles/dev_tools/tasks/commands/gh.yaml index b4bea9a..992d223 100644 --- a/ansible/roles/dev_tools/tasks/commands/gh.yaml +++ b/ansible/roles/dev_tools/tasks/commands/gh.yaml @@ -1,5 +1,4 @@ - name: setup gh command - become: true block: - name: get gpg key ansible.builtin.get_url: diff --git a/ansible/roles/init_snap/tasks/main.yaml b/ansible/roles/init_snap/tasks/main.yaml index 706fa07..1d70bdc 100644 --- a/ansible/roles/init_snap/tasks/main.yaml +++ b/ansible/roles/init_snap/tasks/main.yaml @@ -1,5 +1,4 @@ - name: refresh snap - become: true command: snap refresh when: not is_ci changed_when: false diff --git a/ansible/roles/system_tools/tasks/commands/tmux.yaml b/ansible/roles/system_tools/tasks/commands/tmux.yaml index 4d5e1b3..e6b645a 100644 --- a/ansible/roles/system_tools/tasks/commands/tmux.yaml +++ b/ansible/roles/system_tools/tasks/commands/tmux.yaml @@ -13,11 +13,13 @@ changed_when: false - name: backup .tmux.conf if already exists + become: false ansible.builtin.shell: >- mv "{{ lookup('env', 'HOME') }}/.tmux.conf" "{{ lookup('env', 'HOME') }}/.tmux.conf.bak" when: tmux_conf_exists.stat.exists and not tmux_conf_exists.stat.islnk - name: create symlink to .tmux.conf(unless symlink does not already exist) + become: false file: src: "{{ (playbook_dir + '/../.tmux.conf') | realpath }}" dest: "{{ lookup('env', 'HOME') }}/.tmux.conf" @@ -31,11 +33,13 @@ changed_when: false - name: backup .config/tmux if already exists + become: false ansible.builtin.shell: >- mv "{{ lookup('env', 'HOME') }}/.config/tmux" "{{ lookup('env', 'HOME') }}/.config/tmux.bak" when: config_tmux_d_exists.stat.exists and not config_tmux_d_exists.stat.islnk - name: create symlink to .config/tmux(unless symlink does not already exist) + become: false file: src: "{{ (playbook_dir + '/../.config/tmux') | realpath }}" dest: "{{ lookup('env', 'HOME') }}/.config/tmux" diff --git a/ansible/roles/xdg_base_directory/tasks/main.yaml b/ansible/roles/xdg_base_directory/tasks/main.yaml index ae79c65..d317aa8 100644 --- a/ansible/roles/xdg_base_directory/tasks/main.yaml +++ b/ansible/roles/xdg_base_directory/tasks/main.yaml @@ -16,6 +16,8 @@ ansible.builtin.shell: echo $PATH register: out +- debug: var=out.stdout_lines + - name: check ls ansible.builtin.shell: ls -a {{ lookup('env','HOME') }} register: out