Deploy is marked as successful if thrown error message is empty

[birtles]

If you do the following in your workflow:

throw new Error('');

The deploy is treated as successful.

Why does this matter? A lot of tasks fail without writing anything to stderr, e.g. sst deploy itself.

As a result, if you do await $`pnpm sst deploy` we write an empty string to WORKFLOW_RESULT file:

console/packages/build/buildspec/index.mjs

Lines 383 to 386 in 6ef9bf9

	` const result = e.name === "ShellError"`,
	` ? { error: e.stderr.toString().trim() }`,
	` : { error: e.message };`,
	` fs.writeFileSync("${WORKFLOW_RESULT}", JSON.stringify(result));`,

That gets transformed into an Error with an empty message here:

console/packages/build/buildspec/index.mjs

Lines 395 to 400 in 6ef9bf9

	try {
	shellError = new Error(
	JSON.parse(fs.readFileSync(WORKFLOW_RESULT, "utf8")).error,
	);
	} catch (_) {}
	throw shellError;

As a result, even if sst deploy fails (or astro check or tsc --noEmit etc.) the deploy is treated as successful. Furthermore, steps following the error don't run.

[birtles]

For what it's worth, I'm currently working around this by wrapping every command up in an explicit exit code check and re-throwing as regular Error (not a ShellError):

{
  const { exitCode } = await $`pnpm astro check`.nothrow();
  if (exitCode !== 0) {
    throw new Error('`astro check` failed');
  }
}