Skip to content

Commit e5a2f71

Browse files
committed
ret needs to be false if set_user_groups fails
1 parent 14c2046 commit e5a2f71

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/sudo.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1411,9 +1411,11 @@ policy_init_session(struct command_details *details)
14111411
* groups to be set via pam_group(8) in pam_setcred(3).
14121412
*/
14131413
if (ISSET(details->flags, CD_SET_GROUPS)) {
1414-
/* set_user_groups() prints error message on failure. */
1415-
if (!set_user_groups(details))
1416-
goto done;
1414+
/* set_user_groups() prints error message on failure. */
1415+
if (!set_user_groups(details)) {
1416+
ret = false;
1417+
goto done;
1418+
}
14171419
}
14181420

14191421
/* Session setup may override sudoers umask so set it first. */

0 commit comments

Comments
 (0)