From 32d98c24825cb2565a8f634b0e07374e8567f284 Mon Sep 17 00:00:00 2001 From: AZero13 Date: Thu, 18 Dec 2025 11:11:44 -0500 Subject: [PATCH] ret needs to be false if set_user_groups fails --- src/sudo.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/sudo.c b/src/sudo.c index 82541f224c..0d1667d505 100644 --- a/src/sudo.c +++ b/src/sudo.c @@ -1411,9 +1411,11 @@ policy_init_session(struct command_details *details) * groups to be set via pam_group(8) in pam_setcred(3). */ if (ISSET(details->flags, CD_SET_GROUPS)) { - /* set_user_groups() prints error message on failure. */ - if (!set_user_groups(details)) - goto done; + /* set_user_groups() prints error message on failure. */ + if (!set_user_groups(details)) { + ret = false; + goto done; + } } /* Session setup may override sudoers umask so set it first. */