test fix

Author: VaghinakDev

src/superannotate/lib/core/serviceproviders.py

@@ -346,7 +346,7 @@ async def download_big_annotation(
         project: entities.ProjectEntity,
         download_path: str,
         postfix: str,
-        item: dict,
+        item: entities.BaseItemEntity,
         callback: Callable = None,
     ):
         raise NotImplementedError

src/superannotate/lib/core/usecases/annotations.py

@@ -1408,7 +1408,10 @@ def validate_item_names(self):
                     f"Dropping duplicates. Found {len_unique_items}/{len_items} unique items."
                 )
             #  Keep order required
-            self._item_names = [i for i in self._item_names if i in unique_item_names]
+            seen = set()
+            self._item_names = [
+                i for i in self._item_names if not (i in seen or seen.add(i))
+            ]
         elif self._item_names is None:
             self._item_names_provided = False
             condition = Condition("project_id", self._project.id, EQ) & Condition(

src/superannotate/lib/core/usecases/projects.py

@@ -772,7 +772,7 @@ def __init__(
 
     def execute(self):
         if self.is_valid():
-            team_users = {user.email for user in self._team.users}
+            team_users = {user["email"] for user in self._team.users}
             # collecting pending team users
             team_users.update(
                 {user["email"] for user in self._team.pending_invitations}

src/superannotate/lib/infrastructure/services/annotation.py

@@ -187,11 +187,11 @@ async def download_big_annotation(
         project: entities.ProjectEntity,
         download_path: str,
         postfix: str,
-        item: dict,
+        item: entities.BaseItemEntity,
         callback: Callable = None,
     ):
-        item_id = item["id"]
-        item_name = item["name"]
+        item_id = item.id
+        item_name = item.name
         query_params = {
             "team_id": project.team_id,
             "project_id": project.id,

tests/integration/annotations/test_download_annotations.py

@@ -120,3 +120,14 @@ def test_download_annotations_from_folders_mul(self):
                 [i for i in glob.iglob(annotations_path + "**/**", recursive=True)]
             )
             assert count == 31 + 5  # folder names and classes
+
+    def test_download_annotations_duplicated_names(self):
+        self._attach_items(count=4)
+        with tempfile.TemporaryDirectory() as temp_dir:
+            with self.assertLogs("sa", level="INFO") as cm:
+                sa.download_annotations(
+                    self.PROJECT_NAME, temp_dir, [self.IMAGE_NAME] * 4
+                )  # noqa
+                assert (
+                    "INFO:sa:Dropping duplicates. Found 1/4 unique items." in cm.output
+                )

tests/integration/annotations/test_get_annotations.py

@@ -139,6 +139,12 @@ def test_get_annotation(self):  # to_delete
         a = sa.get_annotations(self.PROJECT_NAME)
         assert len(a) == count
 
+    def test_get_annotations_duplicated_names(self):
+        self._attach_items(count=4)
+        with self.assertLogs("sa", level="INFO") as cm:
+            sa.get_annotations(self.PROJECT_NAME, [self.IMAGE_NAME] * 4)
+            assert "INFO:sa:Dropping duplicates. Found 1/4 unique items." in cm.output
+
 
 class TestGetAnnotationsVideo(BaseTestCase):
     PROJECT_NAME = "test attach multiple video urls"