Skip to content

Commit 93e9569

Browse files
authored
Merge pull request #508 from superannotateai/1304_add_items_to_subset
fixing duplicate skip and success items issue
2 parents c9b2127 + fa9c680 commit 93e9569

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/superannotate/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import os
22
import sys
33

4-
__version__ = "4.4.5dev2"
4+
__version__ = "4.4.5dev3"
55

66
sys.path.append(os.path.split(os.path.realpath(__file__))[0])
77

src/superannotate/lib/app/interface/sdk_interface.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3058,7 +3058,7 @@ def add_items_to_subset(
30583058
:param subset: a name of an existing/new subset to associate items with. New subsets will be automatically created.
30593059
:type subset: str
30603060
3061-
:param items: list of items metadata. Required keys are 'name' and 'path'
3061+
:param items: list of items metadata. Required keys are 'name' and 'path' if the 'id' key is not provided in the dict.
30623062
:type items: list of dicts
30633063
30643064
Request Example:

src/superannotate/lib/core/usecases/items.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -833,7 +833,7 @@ def __init__(
833833
self.project = project
834834
self.subset_name = subset_name
835835
self.items = items
836-
self.results = {"failed": [], "skipped": [], "succeeded": []}
836+
self.results = {"succeeded": [], "failed": [], "skipped": []}
837837
self.item_ids = []
838838
self.path_separated = defaultdict(dict)
839839
self._backend_client = backend_client
@@ -969,7 +969,7 @@ def __query(self, path, items):
969969
queried_items = queried_items.data
970970
# Adding the images missing from specified folder to 'skipped'
971971
tmp = {item["name"]: item for item in items["items"]}
972-
tmp_q = (x.name for x in queried_items)
972+
tmp_q = {x.name for x in queried_items}
973973

974974
for i, val in tmp.items():
975975
if i not in tmp_q:
@@ -997,7 +997,7 @@ def validate_items(
997997
filtered_items = self.__filter_duplicates()
998998
if len(filtered_items) != len(self.items):
999999
self.reporter.log_info(
1000-
f"Dropping duplicates found {len(filtered_items)} / {len(self.items)} unique items"
1000+
f"Dropping duplicates. Found {len(filtered_items)} / {len(self.items)} unique items"
10011001
)
10021002
self.items = filtered_items
10031003
self.items = self.__filter_invalid_items()

0 commit comments

Comments
 (0)