image quality settings test

Author: hovnatan

superannotate/db/projects.py

@@ -588,13 +588,16 @@ def get_image_array_to_upload(
         byte_io_orig = io.BytesIO()
         im.save(byte_io_orig, im_format, subsampling=0, quality=100)
 
-    byte_io_lores = io.BytesIO()
-    im.save(
-        byte_io_lores,
-        'JPEG',
-        subsampling=0 if image_quality_in_editor > 60 else 2,
-        quality=image_quality_in_editor
-    )
+    if not image_quality_in_editor == 100 or im_format != "JPEG":
+        byte_io_lores = io.BytesIO()
+        im.save(
+            byte_io_lores,
+            'JPEG',
+            subsampling=0 if image_quality_in_editor > 60 else 2,
+            quality=image_quality_in_editor
+        )
+    else:
+        byte_io_lores = io.BytesIO(byte_io_orig.getbuffer())
 
     byte_io_huge = io.BytesIO()
     hsize = int(height * 600.0 / width)
@@ -1646,10 +1649,10 @@ def _get_project_image_quality_in_editor(project, image_quality_in_editor):
 
 def _set_project_default_image_quality_in_editor(project, quality):
     set_project_settings(
-        project, {
+        project, [{
             "attribute": "ImageQuality",
             "value": quality
-        }
+        }]
     )
 
 

tests/test_image_quality.py

@@ -0,0 +1,55 @@
+from pathlib import Path
+import filecmp
+
+import superannotate as sa
+
+import pytest
+
+PROJECT_NAME1 = "test image qual setting1"
+PROJECT_NAME2 = "test image qual setting2"
+
+
+def test_image_quality_setting1(tmpdir):
+    tmpdir = Path(tmpdir)
+
+    projects = sa.search_projects(PROJECT_NAME1, return_metadata=True)
+    for project in projects:
+        sa.delete_project(project)
+
+    project = sa.create_project(PROJECT_NAME1, "test", "Vector")
+
+    sa.upload_images_from_folder_to_project(
+        project, "./tests/sample_project_vector"
+    )
+
+    sa.download_image(project, "example_image_1.jpg", tmpdir, variant="lores")
+
+    assert not filecmp.cmp(
+        tmpdir / "example_image_1.jpg___lores.jpg",
+        "./tests/sample_project_vector/example_image_1.jpg",
+        shallow=False
+    )
+
+
+def test_image_quality_setting2(tmpdir):
+    tmpdir = Path(tmpdir)
+
+    projects = sa.search_projects(PROJECT_NAME2, return_metadata=True)
+    for project in projects:
+        sa.delete_project(project)
+
+    project = sa.create_project(PROJECT_NAME2, "test", "Vector")
+
+    sa.set_project_default_image_quality_in_editor(project, "original")
+
+    sa.upload_images_from_folder_to_project(
+        project, "./tests/sample_project_vector"
+    )
+
+    sa.download_image(project, "example_image_1.jpg", tmpdir, variant="lores")
+
+    assert filecmp.cmp(
+        tmpdir / "example_image_1.jpg___lores.jpg",
+        "./tests/sample_project_vector/example_image_1.jpg",
+        shallow=False
+    )