Improve test metadata test

Author: hovnatan

superannotate/db/teams.py

@@ -30,7 +30,7 @@ def invite_contributor_to_team(email, admin=False):
     return response.json()
 
 
-def get_team_metadata(convert_users_role_to_string=False):
+def get_team_metadata():
     """Returns team metadata
 
     :param convert_users_role_to_string: convert integer team users' roles to human comprehensible strings
@@ -45,9 +45,8 @@ def get_team_metadata(convert_users_role_to_string=False):
         )
 
     res = response.json()
-    if convert_users_role_to_string:
-        for user in res["users"]:
-            user["user_role"] = user_role_int_to_str(user["user_role"])
+    for user in res["users"]:
+        user["user_role"] = user_role_int_to_str(user["user_role"])
 
     return res
 

tests/test_team_metadata.py

@@ -6,6 +6,16 @@
 
 
 def test_team_metadata():
-    metadata = sa.get_team_metadata(convert_users_role_to_string=True)
-    print(len(metadata["users"]))
-    print(metadata["users"])
+    metadata = sa.get_team_metadata()
+    print(metadata)
+    assert all(
+        [x in metadata for x in ["id", "users", "name", "description", "type"]]
+    )
+
+    for user in metadata["users"]:
+        assert all(
+            [
+                x in user for x in
+                ["id", "email", "first_name", "last_name", "user_role"]
+            ]
+        )