Skip to content

fix build for recent... macos? readline? ruby? #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix build for recent... macos? readline? ruby? #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d23dde8
fix build
jjb Apr 7, 2024
671d78c
more needed fixes?
jjb Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ GEM
specs:
coderay (1.1.2)
diff-lcs (1.3)
ffi (1.10.0)
ffi (1.17.0)
filigree (0.3.3)
method_source (0.9.2)
pry (0.12.2)
Expand Down Expand Up @@ -33,3 +33,6 @@ DEPENDENCIES
pry
rltk
rspec

BUNDLED WITH
2.5.23
4 changes: 2 additions & 2 deletions ext/gitsh/src/line_editor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,7 +1164,7 @@ readline_s_set_completer_word_break_characters(VALUE self, VALUE str)
* Raises NotImplementedError if the using readline library does not support.
*/
static VALUE
readline_s_get_completer_word_break_characters(VALUE self, VALUE str)
readline_s_get_completer_word_break_characters(VALUE str)
{
if (rl_completer_word_break_characters == NULL)
return Qnil;
Expand Down Expand Up @@ -1282,7 +1282,7 @@ readline_s_set_completer_quote_characters(VALUE self, VALUE str)
* Raises NotImplementedError if the using readline library does not support.
*/
static VALUE
readline_s_get_completer_quote_characters(VALUE self, VALUE str)
readline_s_get_completer_quote_characters(VALUE str)
{
if (rl_completer_quote_characters == NULL)
return Qnil;
Expand Down