Commit graph color doesn't follow color scheme changes

[tibirna]

Start qgit in a light color scheme. Observe the main color of the commit graph (black). With qgit running, change the global color scheme (e.g. in KDE using System Settings > Appearance > Color > Breeze Dark). Observe that the main color of the commit graph remains black (and thus barely visible in the new color scheme). With the color scheme still dark, restart qgit and notice the commit graph main color (now white). Change the color scheme back to light. Notice the commit graph color staying white, i.e. barely visible in the new color scheme.

To fix: ensure graph is redrawn on color scheme change events.

[david0sen]

This is how it looks for me with my system using a dark theme...

The graph/rev-list area shows the background in light mode, which makes it impossible to read.

This used to work fine in the past...

[tibirna]

@david0sen this used to be an issue back before 2023. It was an issue in the Qt library. Thanks for redrawing my attention to it.

I just tested it with QGit-2.12 compiled on Qt-6.9.1 and the issue is resolved.

Please state the versions of the QGit you use and the Qt version it is compiled with (it is indicated in the Help > About QGit dialog.

[david0sen]

@tibirna The versions in "About QGit" are:

QGit version 2.10
Compiled against Qt 5.15.14

Fedora 41 does not provide newer versions of Qgit or Qt:

# dnf list qt
Updating and loading repositories:
Repositories loaded.
Installed packages
qt.x86_64 1:4.8.7-77.fc41 fedora

Available packages
qt.i686   1:4.8.7-77.fc41 fedora

# dnf list qgit
Updating and loading repositories:
Repositories loaded.
Installed packages
qgit.x86_64 2.10-7.fc41 fedora

Perhaps I should compile from sources... does it have too many dependencies?
I wonder how things will clash with all the desktop stuff uasing the existing Qt...

[tibirna]

@david0sen I tested a bit more and the issue you report is apparently caused by some issue in applying colour themes to Qt apps in your distribution. Maybe, if you have some other Qt-based app using a tree view, you could determine if all applications are affected.

I can't reproduce the issue you report in the systems I have access to.

OTOH, the original report above is about a different issue. It is about the colour of the main lane in the left-hand-side graph. That issue is still present and is internal to QGit, independent of Qt version. I added some screenshots to make clear what the report is about.

[david0sen]

Hi tbirna, Other apps, like gitg (i believe it runs in flatpak), gitfourvhette, gittyup, git-cola, gitsmart, seems to do it correctly. I like QGit more, so I try to stick with it. I believe this used to work and go broken relatively recently. Anyway, let me know if thete is any data or tests that I can provide for this to be solved. Maybe applying or changing some qt configuration? I remember there is a qt utility for that... Regards, David

[tibirna]

@david0sen thanks for the testing. Speaking of flatpaks, would you agree to install and test https://flathub.org/apps/org.tibirna.qgit and write back with whether the issue is still present?

[david0sen]

Sure.

[david0sen]

Hi @tibirna,

Sorry for the delay.

I have tested the flatpak you linked above, and it works fine... only funny thing is that it tries to use kompara for diffs and cannot find where that is configured... I have meld and diffuse configured in the git config.

Cheers

[tibirna]

@david0sen thank you for the test. This confirms that the issue is with the Qt library of your distro. If you can use the flatpak, I think this is the workaround until a correction is made in Fedora.

To configure the diff viewer, go to Edit > Settings > General > External diff tool and replace kompare with your preferred tool.

[david0sen]

Don't know how I missed it... thanks