Skip to content

Incorrect file-to-diff jump when the diff contains patch files #144

@hosiet

Description

@hosiet

It looks like the parsing of git diff output is not robust enough so that it can be confused by the diff of a patch. See below on how to reproduce the bug.

  • Operation system: Debian Testing (2024-04)
  • Git version: 2.43.0
  • qgit version: Git HEAD (cf3350e 2024-02-03), built with cmake . ; make. The bug is also present with qgit 2.10

How to reproduce the bug

  • Decompress the attached tarball.
  • Open qgit in the extracted directory. View all history when opening.
  • In the Rev list page, click the row containing the upstream branch (aka tag upstream/1.2+git20230914).
  • In the file list on the bottom-right side, click the pref.js row.
  • The diff on the left side does not show the diff of pref.js file, which is the bug. Instead, it is showing diff of /debian/patches/set-gtk-3.0-to-prevent-importing-4.0.patch.

Attached tarball

sample_ibus-avro.tar.xz.zip

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions