Search highlight color unreadable in dark mode

[Zesko]

In dark mode, the highlight color for search keywords is blue, which is hard to read.

Steps to reproduce:

1. Open QGit and go to the search.
2. Select Patch to search content in a folder.
3. Enter any keyword to search.
4. Check the Diff view
5. The matched keywords are highlighted in blue, which is hard to read in dark mode.

Is there a way to configure only the search highlight color in qgit?

[WickedSmoke]

There's a few issues with palette changes and this also affects colors in the commit summary (class RevDesc).

If the system palette changes when the program is running some widgets don't update properly. This may be a Qt problem. Closing and then reopening a tab should cause the colors to update. On my system I've seen three different colors for the highlighted text after changing to a dark palette, but only one was unreadable.

What's never readable is the hard-coded yellow background for the ExtraSelection of the search words. There is a fix for this in my repository. Here's a before & after screen shot:

This still requires closing the tab or restarting the program for the colors to update, and the color selection algorithm still needs some tweaking.

[Zesko]

There is a fix for this in my repository. Here's a before & after screen shot:

The issue is still present on KDE Plasma (Qt6).

Is there a way to change the blue color to a color of my choice?

[WickedSmoke]

@Zesko Those colors are hardcoded in DiffHighlighter. I'll see if I can mix a color as I did with the yellow Find color.

[WickedSmoke]

There's a new dev branch commit to match the DiffHighlighter search colors with the Find action, so give that a try.

[tibirna]

@WickedSmoke thanks for looking into this. @Zesko the highlight color was hardcoded (as all colors for the patch viewer). No way to change it for the user directly. While the other patch colors are somewhat adapted to light vs dark color schemes, the selection (highlighting) color was not. The change proposed by @WickedSmoke might be a suitable solution.

The general handling of patch coloring is a bit fragile and adhoc (code dates from 15 years ago). A general solution which properly precalculates the colors (and avoid calculating them over and over again in the DiffHighlighter::highlightBlock method will be needed eventually.

[WickedSmoke]

There are now a few more commits that apply palette changes to RevDesc, DiffHighlighter, & FileHighlighter without having to re-open their tabs.

[Zesko]

@WickedSmoke it looks good to me. Thanks!