From edccec66bb072b3bb4a0d92b84fa0cb377f6c109 Mon Sep 17 00:00:00 2001 From: kobayu858 Date: Fri, 19 Sep 2025 19:16:13 +0900 Subject: [PATCH 1/2] refactor: removed assert Signed-off-by: kobayu858 --- applications/rd_gen_to_dags/src/build_dag.rs | 22 -------------------- applications/rd_gen_to_dags/src/lib.rs | 5 +++++ 2 files changed, 5 insertions(+), 22 deletions(-) diff --git a/applications/rd_gen_to_dags/src/build_dag.rs b/applications/rd_gen_to_dags/src/build_dag.rs index 3eb6e3645..843d74443 100644 --- a/applications/rd_gen_to_dags/src/build_dag.rs +++ b/applications/rd_gen_to_dags/src/build_dag.rs @@ -119,10 +119,6 @@ async fn register_source_node( let out_links_num = node_data.get_out_links().len(); - assert!( - out_links_num == 0, - "LinkNumError::NoInput: dag_id={dag_id}, node_id={node_id}" - ); match out_links_num { 1 => register_source!(dag, node_data, sched_type, u64), @@ -174,11 +170,6 @@ async fn register_sink_node( let in_links_num = node_data.get_in_links().len(); - assert!( - in_links_num == 0, - "LinkNumError::NoInput: dag_id={dag_id}, node_id={node_id}" - ); - match in_links_num { 1 => register_sink!(dag, node_data, sched_type, u64), 2 => register_sink!(dag, node_data, sched_type, u64, u64), @@ -242,19 +233,6 @@ async fn register_intermediate_node( let in_links_num = node_data.get_in_links().len(); let out_links_num = node_data.get_out_links().len(); - assert!( - in_links_num > 0 && out_links_num > 0, - "LinkNumError::NoInOut: dag_id={dag_id}, node_id={node_id}" - ); - assert!( - in_links_num == 0, - "LinkNumError::NoInput: dag_id={dag_id}, node_id={node_id}", - ); - assert!( - out_links_num == 0, - "LinkNumError::NoOutput: dag_id={dag_id}, node_id={node_id}", - ); - match (in_links_num, out_links_num) { (1, 1) => register_intermediate!(dag, node_data, sched_type, u64; u64), (1, 2) => register_intermediate!(dag, node_data, sched_type, u64; u64, u64), diff --git a/applications/rd_gen_to_dags/src/lib.rs b/applications/rd_gen_to_dags/src/lib.rs index ab06cdd6e..606c2016c 100644 --- a/applications/rd_gen_to_dags/src/lib.rs +++ b/applications/rd_gen_to_dags/src/lib.rs @@ -48,6 +48,11 @@ pub async fn run() { } } + if success_build_dags.is_empty() { + log::error!("Failed to build DAG"); + return; + } + match finish_create_dags(&success_build_dags).await { Ok(_) => { log::info!("DAGs created successfully."); From 93e38d1530fdd6cc2069f25233a099541a53a0b5 Mon Sep 17 00:00:00 2001 From: kobayu858 Date: Fri, 19 Sep 2025 19:19:48 +0900 Subject: [PATCH 2/2] refactor: cargo fmt Signed-off-by: kobayu858 --- applications/rd_gen_to_dags/src/build_dag.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/applications/rd_gen_to_dags/src/build_dag.rs b/applications/rd_gen_to_dags/src/build_dag.rs index 843d74443..b6af74cad 100644 --- a/applications/rd_gen_to_dags/src/build_dag.rs +++ b/applications/rd_gen_to_dags/src/build_dag.rs @@ -119,7 +119,6 @@ async fn register_source_node( let out_links_num = node_data.get_out_links().len(); - match out_links_num { 1 => register_source!(dag, node_data, sched_type, u64), 2 => register_source!(dag, node_data, sched_type, u64, u64),