vboxguestadditions_spec fails

[justizin]

This test in tests/spec/common/vboxguestadditions_spec fails, although scripts/common/cleanup.sh clearly removes this file:

describe file('/tmp/VBoxGuestAdditions.iso') do
  it { should_not be_file }
end

Disabling this test allows the build to succeed, but that doesn't seem an appropriate fix. :)

[justizin]

I submitted PR #25 which seems to resolve this.

[tmclaugh]

How did #25 fix this issue? I don't see a change which would have affected the file.

[justizin]

That's actually a fantastic question, I don't know why I didn't initially clarify.

#25 actually fixes what I believe to be an adjacent issue. Once that issue is resolved, this problem goes away, consistently, on multiple machines.

I would love to better understand why, I'm getting to know the project better as I iterate myself.