From 10dee4fb101f6ede0e0a74354f3a76d74351aacb Mon Sep 17 00:00:00 2001
From: Ivan Cherevko <i@cherevko.net>
Date: Wed, 7 Sep 2011 09:26:10 +0300
Subject: [PATCH] Logging behavior changes, remove unused import
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

“Import os” is unused, also, changed logging behavior to pass both
format and parameter separately to logger to avoid interpolating strings
if no logging takes place.
---
 littleworkers.py | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/littleworkers.py b/littleworkers.py
index 1a408bf..81814cf 100644
--- a/littleworkers.py
+++ b/littleworkers.py
@@ -1,5 +1,4 @@
 import logging
-import os
 import subprocess
 import time
 
@@ -101,7 +100,7 @@ def create_process(self, command):
         Given a provided command (string or list), creates a new process
         to execute the command.
         """
-        logging.debug("Starting process to handle command '%s'." % command)
+        logging.debug("Starting process to handle command '%s'.", command)
         kwargs = self.process_kwargs(command)
         return subprocess.Popen(command, **kwargs)
     
@@ -118,7 +117,7 @@ def add_to_pool(self, proc):
         """
         Adds a process to the pool.
         """
-        logging.debug("Adding %s to the pool." % proc.pid)
+        logging.debug("Adding %s to the pool.", proc.pid)
         self.pool[proc.pid] = proc
     
     def remove_from_pool(self, pid):
@@ -129,7 +128,7 @@ def remove_from_pool(self, pid):
         ``Pool.debug = True``).
         """
         try:
-            logging.debug("Removing %s from the pool" % pid)
+            logging.debug("Removing %s from the pool", pid)
             del(self.pool[pid])
         except KeyError:
             if self.debug:
@@ -144,7 +143,7 @@ def inspect_pool(self):
         """
         # Call ``len()`` just once.
         pool_size = len(self.pool)
-        logging.debug("Current pool size: %s" % pool_size)
+        logging.debug("Current pool size: %s", pool_size)
         return pool_size
     
     def busy_wait(self):
@@ -185,7 +184,7 @@ def run(self, commands=None, callback=None):
             
             # Go in reverse order so offsets never get screwed up.
             for pid in self.pool.keys():
-                logging.debug("Checking status on %s" % self.pool[pid].pid)
+                logging.debug("Checking status on %s", self.pool[pid].pid)
                 
                 if self.pool[pid].poll() >= 0:
                     if self.callback: