Initial change handle functionality #1434
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| .container { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 20px; | ||
| position: relative; | ||
| } | ||
|
|
||
| .blockForm { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 20px; | ||
| position: relative; | ||
| } | ||
|
|
||
| .actionButtons { | ||
| display: flex; | ||
| justify-content: flex-end; | ||
| gap: 6px; | ||
| } | ||
|
|
||
| .dialogLoadingSpinnerContainer { | ||
| position: absolute; | ||
| width: 64px; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| bottom: 0; | ||
| height: 64px; | ||
| left: 0; | ||
|
|
||
| .spinner { | ||
| background: none; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /** | ||
| * Dialog edit user handle. | ||
| */ | ||
| import { FC, useCallback, useState } from 'react' | ||
| import { useForm, UseFormReturn } from 'react-hook-form' | ||
| import { toast } from 'react-toastify' | ||
| import _ from 'lodash' | ||
| import classNames from 'classnames' | ||
|
|
||
| import { | ||
| BaseModal, | ||
| Button, | ||
| ConfirmModal, | ||
| InputText, | ||
| LoadingSpinner, | ||
| } from '~/libs/ui' | ||
| import { yupResolver } from '@hookform/resolvers/yup' | ||
|
|
||
| import { FormEditUserHandle, UserInfo } from '../../models' | ||
| import { formEditUserHandleSchema, handleError } from '../../utils' | ||
| import { changeUserHandle } from '../../services' | ||
|
|
||
| import styles from './DialogEditUserHandle.module.scss' | ||
|
|
||
| interface Props { | ||
| className?: string | ||
| open: boolean | ||
| setOpen: (isOpen: boolean) => void | ||
| userInfo: UserInfo | ||
| } | ||
|
|
||
| export const DialogEditUserHandle: FC<Props> = (props: Props) => { | ||
| const [isLoading, setIsLoading] = useState(false) | ||
| const handleClose = useCallback(() => { | ||
| if (!isLoading) { | ||
| props.setOpen(false) | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [isLoading]) | ||
|
There was a problem hiding this comment. [ |
||
| const [showConfirm, setShowConfirm] = useState(false) | ||
| const { | ||
| register, | ||
| handleSubmit, | ||
| getValues, | ||
| formState: { errors, isValid, isDirty }, | ||
| }: UseFormReturn<FormEditUserHandle> = useForm({ | ||
| defaultValues: { | ||
| newHandle: '', | ||
| }, | ||
| mode: 'all', | ||
| resolver: yupResolver(formEditUserHandleSchema), | ||
| }) | ||
| const onSubmit = useCallback(() => { | ||
| setShowConfirm(true) | ||
| }, []) | ||
| const currentHandle = props.userInfo.handle | ||
|
There was a problem hiding this comment. [ |
||
| const newHandle = getValues().newHandle ?? '' | ||
| const confirmMessage = `Are you sure you want to change the handle from "${currentHandle}" ` | ||
| + `to "${newHandle}"?` | ||
|
|
||
| return ( | ||
| <> | ||
| <BaseModal | ||
| allowBodyScroll | ||
| blockScroll | ||
| title={`Change handle for ${props.userInfo.handle}`} | ||
| onClose={handleClose} | ||
| open={props.open} | ||
| > | ||
| <form | ||
| className={classNames(styles.container, props.className)} | ||
| onSubmit={handleSubmit(onSubmit)} | ||
| > | ||
| <div className={styles.blockForm}> | ||
| <InputText | ||
| type='text' | ||
| name='currentHandle' | ||
| label='Current Handle' | ||
| placeholder='Enter' | ||
| tabIndex={0} | ||
| forceUpdateValue | ||
| onChange={_.noop} | ||
| disabled | ||
| value={props.userInfo.handle} | ||
| /> | ||
| <InputText | ||
| type='text' | ||
| name='newHandle' | ||
| label='New Handle' | ||
| placeholder='Enter' | ||
| tabIndex={0} | ||
| forceUpdateValue | ||
| onChange={_.noop} | ||
| error={_.get(errors, 'newHandle.message')} | ||
| inputControl={register('newHandle')} | ||
|
There was a problem hiding this comment. [💡 |
||
| dirty | ||
| disabled={isLoading} | ||
| /> | ||
| </div> | ||
| <div className={styles.actionButtons}> | ||
| <Button | ||
| secondary | ||
| size='lg' | ||
| onClick={handleClose} | ||
| disabled={isLoading} | ||
| > | ||
| Cancel | ||
| </Button> | ||
| <Button | ||
| type='submit' | ||
| primary | ||
| size='lg' | ||
| disabled={isLoading || !isValid || !isDirty} | ||
| > | ||
| Continue | ||
| </Button> | ||
| </div> | ||
|
|
||
| {isLoading && ( | ||
| <div className={styles.dialogLoadingSpinnerContainer}> | ||
| <LoadingSpinner className={styles.spinner} /> | ||
| </div> | ||
| )} | ||
| </form> | ||
| </BaseModal> | ||
| <ConfirmModal | ||
| allowBodyScroll | ||
| blockScroll | ||
| focusTrapped={false} | ||
| title='Confirm Handle Change' | ||
| action='Confirm' | ||
| onClose={function onClose() { | ||
| setShowConfirm(false) | ||
| }} | ||
| onConfirm={function onConfirm() { | ||
| setShowConfirm(false) | ||
| setIsLoading(true) | ||
| const data = getValues() | ||
| const nextHandle = (data.newHandle ?? '').trim() | ||
|
|
||
| changeUserHandle(props.userInfo.handle, nextHandle) | ||
| .then(result => { | ||
| setIsLoading(false) | ||
| toast.success('Handle updated successfully') | ||
| props.userInfo.handle = result?.handle ?? nextHandle | ||
|
There was a problem hiding this comment. [ |
||
| handleClose() | ||
| }) | ||
| .catch(e => { | ||
| handleError(e) | ||
| setIsLoading(false) | ||
| }) | ||
| }} | ||
| open={showConfirm} | ||
| > | ||
| <div> | ||
| <p>{confirmMessage}</p> | ||
| </div> | ||
| </ConfirmModal> | ||
| </> | ||
| ) | ||
| } | ||
|
|
||
| export default DialogEditUserHandle | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { default as DialogEditUserHandle } from './DialogEditUserHandle' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| /** | ||
| * Model for edit user handle form | ||
| */ | ||
| export interface FormEditUserHandle { | ||
| newHandle: string | ||
|
There was a problem hiding this comment. [ |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[⚠️
maintainability]Using
position: absolute;for.dialogLoadingSpinnerContainerwithout specifying atop,right, orbottomvalue other thanbottom: 0;can lead to layout issues if the parent container's size changes. Consider ensuring the parent container has a defined size or constraints to prevent unexpected behavior.