fatal error: sys/timex.h: No such file or directory

[ryandesign]

As reported to MacPorts by @barracuda156, htpdate 2.0.1 fails to build on Mac OS X 10.5:

htpdate.c:48:10: fatal error: sys/timex.h: No such file or directory
   48 | #include <sys/timex.h>
      |          ^~~~~~~~~~~~~

The sys/timex.h header first appeared in macOS 10.13.

[twekkel]

Mac OS X Leopard version 10.5 was released in 2007 and EOL since 2011... or am I missing something?

[barracuda156]

Well, it is the last macOS to support ppc64, but in any case, the same issue affects macOS up to 10.12, it is not specific to 10.5.

[twekkel]

Right... if somebody has a workaround/fix, please create a PR.

[barracuda156]

Conditionally excluding the header is easy, but there are a few places where timex stuff is used.

htpdate/htpdate.c

Lines 556 to 564 in 1e57b05

	static int setstatus() {
	struct timex txc = {0};
	txc.modes = MOD_STATUS | MOD_ESTERROR | MOD_MAXERROR;
	txc.status &= ~STA_UNSYNC;
	printlog(0, "Set clock synchronized");
	return(adjtimex(&txc));
	}

htpdate/htpdate.c

Lines 613 to 674 in 1e57b05

	static int init_frequency(char *driftfile) {
	struct timex tmx;
	FILE *fp;
	fp = fopen(driftfile, "r");
	if (fp != NULL) {
	if (fscanf(fp, "%li", &tmx.freq)) {
	printlog(0, "Reading frequency from file %li", tmx.freq);
	fclose(fp);
	} else {
	printlog(1, "Error reading frequency from %s", driftfile);
	fclose(fp);
	return -1;
	}
	} else {
	printlog(1, "Error reading frequency from %s", driftfile);
	return -1;
	}
	if ((tmx.freq < -MAX_DRIFT) || (tmx.freq > MAX_DRIFT))
	tmx.freq = sign(tmx.freq) * MAX_DRIFT;
	printlog(0, "Set frequency: %li", tmx.freq);
	tmx.modes = MOD_FREQUENCY;
	/* Become root */
	swuid(0);
	return(adjtimex(&tmx));
	}
	static int htpdate_adjtimex(double drift, char *driftfile, float confidence) {
	struct timex tmx;
	FILE *fp;
	/* Read current clock frequency */
	tmx.modes = 0;
	adjtimex(&tmx);
	/* Weighted average of current and new frequency */
	tmx.freq = tmx.freq + (long int)(65536e6 * drift * confidence);
	if ((tmx.freq < -MAX_DRIFT) || (tmx.freq > MAX_DRIFT))
	tmx.freq = sign(tmx.freq) * MAX_DRIFT;
	printlog(0, "Set frequency %li", tmx.freq);
	tmx.modes = MOD_FREQUENCY;
	if (driftfile) {
	fp = fopen(driftfile, "w");
	if (fp != NULL) {
	printlog(0, "Update %s", driftfile);
	fprintf(fp, "%li", tmx.freq);
	fclose(fp);
	} else {
	printlog(1, "Error writing frequency to %s", driftfile);
	}
	}
	/* Become root */
	swuid(0);
	return(adjtimex(&tmx));
	}

htpdate/htpdate.c

Line 1047 in 1e57b05

if (htpdate_adjtimex(drift, driftfile, (float)sleeptime / (float)maxsleep) < 0)

@ryandesign Ryan, do you know if there is a suitable fallback?

[ryandesign]

I have no knowledge of this.