Refactor test server to use TestServer struct

Author: cequele

spec/lib/twingly/http_spec.rb

@@ -537,23 +537,19 @@ class CustomError < StandardError; end
 
   RSpec.shared_examples "verifies proxy functionality" do
     context "when a proxy is provided" do
-      let(:proxy_pid_and_url) { HttpTestServer.spawn("proxy_server") }
-      let(:proxy_pid) { proxy_pid_and_url[0] }
-      let(:proxy_url) { proxy_pid_and_url[1] }
-      let(:target_pid_and_url) { HttpTestServer.spawn("echoed_headers_in_body") }
-      let(:target_pid) { target_pid_and_url[0] }
-      let(:target_url) { target_pid_and_url[1] }
+      let(:proxy_server)  { HttpTestServer.spawn("proxy_server") }
+      let(:target_server) { HttpTestServer.spawn("echoed_headers_in_body") }
       let(:client) do
         described_class.new(
           base_user_agent: base_user_agent,
-          proxy: proxy_url
+          proxy: proxy_server.url
         )
       end
-      let(:url) { target_url }
+      let(:url) { target_server.url }
 
       after do
-        HttpTestServer.stop(proxy_pid)
-        HttpTestServer.stop(target_pid)
+        HttpTestServer.stop(proxy_server.pid)
+        HttpTestServer.stop(target_server.pid)
       end
 
       it "routes requests through the proxy", vcr: false do
@@ -633,6 +629,7 @@ class CustomError < StandardError; end
   describe "#get", vcr: Fixture.example_org do
     include_examples "common HTTP behaviour for", :get, "example.org"
     include_examples "verifies proxy functionality"
+
     let(:request_response) do
       client.get(url)
     end

spec/spec_help/http_test_server.rb

@@ -5,6 +5,8 @@
 module HttpTestServer
   module_function
 
+  TestServer = Struct.new(:pid, :url)
+
   def spawn(server_name, env: {}) # rubocop:disable Metrics/MethodLength
     ip_address = PortProber.localhost
     port = PortProber.random(ip_address)
@@ -23,7 +25,7 @@ def spawn(server_name, env: {}) # rubocop:disable Metrics/MethodLength
       sleep 0.05 until started?(pid) && PortProber.port_open?(ip_address, port)
     end
 
-    [pid, url]
+    TestServer.new(pid, url)
   end
 
   def stop(pid)