From 13163d8cf1fe7934b49e12d91080d77478e3e30e Mon Sep 17 00:00:00 2001 From: IstoraMandiri Date: Wed, 5 Oct 2022 08:46:30 +0000 Subject: [PATCH 1/2] feat: Add tweet preview to PR conversation --- lib/pull-request/create-check-run.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/pull-request/create-check-run.js b/lib/pull-request/create-check-run.js index 966c4182..0c6f6312 100644 --- a/lib/pull-request/create-check-run.js +++ b/lib/pull-request/create-check-run.js @@ -38,6 +38,8 @@ async function createCheckRun( process.exit(allTweetsValid ? 0 : 1); } + const summary = parsedTweets.map(tweetToCheckRunSummary).join("\n\n---\n\n"); + const response = await octokit.request( "POST /repos/:owner/:repo/check-runs", { @@ -54,12 +56,20 @@ async function createCheckRun( conclusion: allTweetsValid ? "success" : "failure", output: { title: `${parsedTweets.length} tweet(s)`, - summary: parsedTweets.map(tweetToCheckRunSummary).join("\n\n---\n\n"), + summary, }, } ); toolkit.info(`check run created: ${response.data.html_url}`); + + // post preview to the PR conversation + await octokit.rest.issues.createComment({ + owner: payload.repository.owner.login, + repo: payload.repository.name, + issue_number: payload.pull_request.number, + body: `## Added ${parsedTweets.length} tweet(s)\n\n${summary}`, + }); } function tweetToCheckRunSummary(tweet) { From 60c745939fdd2e01b33d501cdfea78aeff97e0bd Mon Sep 17 00:00:00 2001 From: IstoraMandiri Date: Wed, 5 Oct 2022 09:40:51 +0000 Subject: [PATCH 2/2] Fix preview summary when parsing threads --- lib/pull-request/create-check-run.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/pull-request/create-check-run.js b/lib/pull-request/create-check-run.js index 0c6f6312..4607ad49 100644 --- a/lib/pull-request/create-check-run.js +++ b/lib/pull-request/create-check-run.js @@ -38,7 +38,9 @@ async function createCheckRun( process.exit(allTweetsValid ? 0 : 1); } - const summary = parsedTweets.map(tweetToCheckRunSummary).join("\n\n---\n\n"); + const summary = parsedTweets + .map((tweet) => tweetToCheckRunSummary(tweet)) + .join("\n\n---\n\n"); const response = await octokit.request( "POST /repos/:owner/:repo/check-runs",