SSL Exception not handled by OnError

[manish-panwar]

Hey Guys,

I am connecting to a server with self-signed cert on SSL, which causes SSL Handshake Exception.

In a vertx world, javax.net.ssl.SSLHandshakeException are handled by the exception handler attached to "HttpClient", not by the exception handler that's attached to "HttpClientRequest". I am proposing following change in RxHttpClient to handle it.

this.core.exceptionHandler(new Handler() {
@OverRide
public void handle(Throwable event) {
rh.fail(event);
}
});

[petermd]

hi manish,

sorry for not responding to this sooner. the problem is that HttpClient.exceptionHandler only keeps one active handler so you would not correctly route exceptions if you had more than one concurrent request.

i think the proper change would require a core fix. you could at least mitigate the impact by ensuring you have a timeout on all requests and log any client level errors.

-peter