From 3b7ba40d934bd1f1e54a14256f45d6cc218c9092 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 12 Oct 2022 10:00:28 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- data_utils.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/data_utils.py b/data_utils.py index f59385a..3c44af6 100644 --- a/data_utils.py +++ b/data_utils.py @@ -67,7 +67,26 @@ def _download(self, download=False): if download: with smart_open.open(self.url, "rb") as file: with tarfile.open(fileobj=file, mode="r") as tgz: - tgz.extractall(self.root) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tgz, self.root) def __getitem__(self, idx): img = PIL.Image.open(self.data[idx]).convert("RGB")