test(e2e): playwright support lazyCompilation after Rsbuild 1.4.0, remove env variable (#2319)

Author: SoonIter

e2e/fixtures/banner/index.test.ts

@@ -3,7 +3,7 @@ import { getPort, killProcess, runDevCommand } from '../../utils/runCommands';
 
 test.describe('tabs-component test', async () => {
   let appPort: number;
-  let app;
+  let app: Awaited<ReturnType<typeof runDevCommand>> | null;
 
   test.beforeAll(async () => {
     const appDir = __dirname;
@@ -18,7 +18,9 @@ test.describe('tabs-component test', async () => {
   });
 
   test('Banner close hides banner and persists state', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}`);
+    await page.goto(`http://localhost:${appPort}`, {
+      waitUntil: 'networkidle',
+    });
     await page.waitForSelector('.rp-banner');
 
     const closeButton = page.locator('.rp-banner__close');

e2e/fixtures/basic/index.test.ts

@@ -17,7 +17,9 @@ test.describe('basic test', async () => {
   });
 
   test('Index page', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}`);
+    await page.goto(`http://localhost:${appPort}`, {
+      waitUntil: 'networkidle',
+    });
     await expect(page.locator('h1')).toContainText('Hello world');
     const headerAnchor = page.locator('.rp-header-anchor').first();
     await expect(headerAnchor).toHaveAttribute('href', '#hello-world');
@@ -47,7 +49,9 @@ test.describe('basic test', async () => {
   });
 
   test('Hover over social links', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}`);
+    await page.goto(`http://localhost:${appPort}`, {
+      waitUntil: 'networkidle',
+    });
     const socialLinks = page.locator('.rp-social-links').first();
     await socialLinks.hover();
     await expect(
@@ -56,7 +60,9 @@ test.describe('basic test', async () => {
   });
 
   test('globalStyles should work', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}`);
+    await page.goto(`http://localhost:${appPort}`, {
+      waitUntil: 'networkidle',
+    });
     const link = page.locator('.rp-doc a').first();
     await expect(link).toHaveCSS('color', 'rgb(255, 165, 0)');
   });

e2e/fixtures/custom-home-footer/index.test.ts

@@ -17,7 +17,9 @@ test.describe('home footer test', async () => {
   });
 
   test('custom home footer', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}`);
+    await page.goto(`http://localhost:${appPort}`, {
+      waitUntil: 'networkidle',
+    });
     const footer = page.locator('footer');
     await expect(footer).toBeVisible();
     await expect(footer.locator('a')).toBeVisible();

e2e/fixtures/github-alert-mdxjs/index.test.ts

@@ -2,8 +2,8 @@ import { expect, test } from '@playwright/test';
 import { getPort, killProcess, runDevCommand } from '../../utils/runCommands';
 
 test.describe('github alert syntax in mdx-js', async () => {
-  let appPort;
-  let app;
+  let appPort: number;
+  let app: Awaited<ReturnType<typeof runDevCommand>> | null;
   test.beforeAll(async () => {
     const appDir = __dirname;
     appPort = await getPort();
@@ -19,7 +19,9 @@ test.describe('github alert syntax in mdx-js', async () => {
   test('should transform github alert syntax to contain syntax', async ({
     page,
   }) => {
-    await page.goto(`http://localhost:${appPort}`);
+    await page.goto(`http://localhost:${appPort}`, {
+      waitUntil: 'networkidle',
+    });
 
     const topLevelCallouts = page.locator('.rspress-doc > .rp-callout');
     await expect(topLevelCallouts).toHaveCount(7);

e2e/fixtures/hmr/index.test.ts

@@ -41,7 +41,9 @@ test.describe('hmr test', async () => {
   });
 
   test('Test page', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}/guide/test.html`);
+    await page.goto(`http://localhost:${appPort}/guide/test.html`, {
+      waitUntil: 'networkidle',
+    });
 
     // basic
     const helloParagraph = page.locator('p', { hasText: 'Hello world' });

e2e/fixtures/i18n/index.test.ts

@@ -208,6 +208,7 @@ test.describe('i18n test', async () => {
       hasText: 'English',
     });
     await englishOption.click();
+    await page.waitForURL(/\/en\//);
 
     const newLanguageSwitcher = page
       .locator('.rp-nav-menu__item')

e2e/fixtures/issue-1309/index.test.ts

@@ -18,7 +18,9 @@ test.describe('issue-1309', async () => {
   });
 
   test('should not generate the sidebar in homePage', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}`);
+    await page.goto(`http://localhost:${appPort}`, {
+      waitUntil: 'networkidle',
+    });
     const navItems = getNavbarItems(page);
     await expect(navItems).toHaveCount(1);
 
@@ -29,7 +31,9 @@ test.describe('issue-1309', async () => {
   test('should render the sidebar correctly in guide page', async ({
     page,
   }) => {
-    await page.goto(`http://localhost:${appPort}/guide`);
+    await page.goto(`http://localhost:${appPort}/guide`, {
+      waitUntil: 'networkidle',
+    });
     const navItems = getNavbarItems(page);
     await expect(navItems).toHaveCount(1);
 

e2e/fixtures/markdown-link-asset/index.test.ts

@@ -7,8 +7,8 @@ import {
 } from '../../utils/runCommands';
 
 test.describe('basic test', async () => {
-  let appPort;
-  let app;
+  let appPort: number;
+  let app: Awaited<ReturnType<typeof runPreviewCommand>> | null;
   test.afterAll(async () => {
     if (app) {
       await killProcess(app);
@@ -21,12 +21,15 @@ test.describe('basic test', async () => {
     cleanUrls: boolean,
   ) {
     if (isI18n) {
-      await page.goto(`http://localhost:${appPort}/base/zh/public-asset-test`);
+      await page.goto(`http://localhost:${appPort}/base/zh/public-asset-test`, {
+        waitUntil: 'networkidle',
+      });
     } else {
-      await page.goto(`http://localhost:${appPort}/base/public-asset-test`);
+      await page.goto(`http://localhost:${appPort}/base/public-asset-test`, {
+        waitUntil: 'networkidle',
+      });
     }
 
-    await page.waitForLoadState('networkidle');
     const links = await page.locator('.rspress-doc p>a').all();
     expect(links.length).toBe(6);
 

e2e/fixtures/markdown-link/index.test.ts

@@ -2,8 +2,8 @@ import { expect, test } from '@playwright/test';
 import { getPort, killProcess, runDevCommand } from '../../utils/runCommands';
 
 test.describe('basic test', async () => {
-  let appPort;
-  let app;
+  let appPort: number;
+  let app: Awaited<ReturnType<typeof runDevCommand>> | null;
   test.beforeAll(async () => {
     const appDir = __dirname;
     appPort = await getPort();
@@ -17,7 +17,9 @@ test.describe('basic test', async () => {
   });
 
   test('all links should be normalized', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}/base/guide`);
+    await page.goto(`http://localhost:${appPort}/base/guide`, {
+      waitUntil: 'networkidle',
+    });
     const links = page.locator('.rspress-doc ul li a');
     const count = await links.count();
     const urls = await Promise.all(

e2e/fixtures/multi-version/index.test.ts

@@ -17,25 +17,33 @@ test.describe('Multi version test', async () => {
   });
 
   test('Default version and default language', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}`);
+    await page.goto(`http://localhost:${appPort}`, {
+      waitUntil: 'networkidle',
+    });
     const h1 = page.locator('h1');
     await expect(h1).toContainText('v1');
   });
 
   test('Not Default version default language', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}/v2`);
+    await page.goto(`http://localhost:${appPort}/v2`, {
+      waitUntil: 'networkidle',
+    });
     const h1 = page.locator('h1');
     await expect(h1).toContainText('v2');
   });
 
   test('Default version not default language', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}/zh`);
+    await page.goto(`http://localhost:${appPort}/zh`, {
+      waitUntil: 'networkidle',
+    });
     const h1 = page.locator('h1');
     await expect(h1).toContainText('v1 中文');
   });
 
   test('Not default version not default language', async ({ page }) => {
-    await page.goto(`http://localhost:${appPort}/v2/zh`);
+    await page.goto(`http://localhost:${appPort}/v2/zh`, {
+      waitUntil: 'networkidle',
+    });
     const h1 = page.locator('h1');
     await expect(h1).toContainText('v2 中文');
   });