Skip to content

Commit ae4d685

Browse files
committed
Remove support for Ruby 3.1 and the aligned JRuby 9.4. Begin adding support for JRuby 10
- rubycritic.gemspec: update minimum Ruby version to 3.2 - .rubocop.yml: update target Ruby version to 3.2 - CI: drop Ruby 3.1 and jruby 9.4 (Ruby 3.1), and convert to testing against jruby 10 - add platform value to the gemspec, and require jar-dependencies version # Conflicts: # CHANGELOG.md
1 parent 85e7742 commit ae4d685

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,14 @@ jobs:
2828
fail-fast: false
2929
matrix:
3030
ruby-version:
31-
- '3.1'
3231
- '3.2'
3332
- '3.3'
3433
- '3.4'
3534
experimental: [false]
3635
include:
3736
- ruby-version: 'ruby-head'
3837
experimental: true
39-
- ruby-version: 'jruby-9.4'
38+
- ruby-version: 'jruby-10'
4039
experimental: true
4140
steps:
4241
- uses: actions/checkout@v6
@@ -59,15 +58,14 @@ jobs:
5958
fail-fast: false
6059
matrix:
6160
ruby-version:
62-
- '3.1'
6361
- '3.2'
6462
- '3.3'
6563
- '3.4'
6664
experimental: [false]
6765
include:
6866
- ruby-version: 'ruby-head'
6967
experimental: true
70-
- ruby-version: 'jruby-9.4'
68+
- ruby-version: 'jruby-10'
7169
experimental: true
7270
steps:
7371
- uses: actions/checkout@v6
@@ -90,15 +88,14 @@ jobs:
9088
fail-fast: false
9189
matrix:
9290
ruby-version:
93-
- '3.1'
9491
- '3.2'
9592
- '3.3'
9693
- '3.4'
9794
experimental: [false]
9895
include:
9996
- ruby-version: 'ruby-head'
10097
experimental: true
101-
- ruby-version: 'jruby-9.4'
98+
- ruby-version: 'jruby-10'
10299
experimental: true
103100
steps:
104101
- uses: actions/checkout@v6
@@ -121,15 +118,14 @@ jobs:
121118
fail-fast: false
122119
matrix:
123120
ruby-version:
124-
- '3.1'
125121
- '3.2'
126122
- '3.3'
127123
- '3.4'
128124
experimental: [false]
129125
include:
130126
- ruby-version: 'ruby-head'
131127
experimental: true
132-
- ruby-version: 'jruby-9.4'
128+
- ruby-version: 'jruby-10'
133129
experimental: true
134130
steps:
135131
- uses: actions/checkout@v6

.rubocop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ AllCops:
1111
- 'tmp/**/*'
1212
- 'vendor/**/*'
1313
- 'gemfiles/*'
14-
TargetRubyVersion: 3.1
14+
TargetRubyVersion: 3.2
1515

1616
Metrics/BlockLength:
1717
Enabled: false

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
* [CHORE] ...
66
* [FEATURE] ...
77

8+
* [CHANGE] Drop support for Ruby 3.1.x and JRuby 9.4 (by [@faisal][])
89
* [CHANGE] Bump mocha dependency (by [@faisal][])
910
* [CHORE] Update CI checkout action to v6 (by [@faisal][]])
1011
* [CHORE] Uses prism instead of parser for Ruby 3.4 and above (by [@torresga][] and [@julioalucero][])

rubycritic.gemspec

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@ require 'rubycritic/version'
77
Gem::Specification.new do |spec|
88
spec.name = 'rubycritic'
99
spec.version = RubyCritic::VERSION
10+
spec.platform = RUBY_PLATFORM == 'java' ? Gem::Platform::JAVA : Gem::Platform::RUBY
1011
spec.authors = ['Guilherme Simoes']
1112
spec.email = ['guilherme.rdems@gmail.com']
1213
spec.description = 'RubyCritic is a tool that wraps around various static analysis gems ' \
1314
'to provide a quality report of your Ruby code.'
1415
spec.summary = 'RubyCritic is a Ruby code quality reporter'
1516
spec.homepage = 'https://github.com/whitesmith/rubycritic'
1617
spec.license = 'MIT'
17-
spec.required_ruby_version = '>= 3.1.0'
18+
spec.required_ruby_version = '>= 3.2.0'
1819

1920
spec.files = [
2021
'CHANGELOG.md',
@@ -46,6 +47,7 @@ Gem::Specification.new do |spec|
4647
spec.add_development_dependency 'aruba', '~> 2.3.1', '>= 2.3.1'
4748
spec.add_development_dependency 'bundler', '>= 2.0.0'
4849
if RUBY_PLATFORM == 'java'
50+
spec.add_development_dependency 'jar-dependencies', '~> 0.5.5'
4951
spec.add_development_dependency 'pry-debugger-jruby'
5052
else
5153
spec.add_development_dependency 'byebug', '~> 12.0', '>= 10.0'

0 commit comments

Comments
 (0)