Skip to content

Return factors and loadings as matrices instead of data frames #28

@willtownes

Description

@willtownes

As pointed out by willtownes/scrna2019#5 glmpca is returning factors as a data frame instead of a matrix (as the documentation claims), which causes downstream problems converting SingleCellExperiment objects to Seurat.

  1. Expose an option to allow the user to decide whether to return matrix or data frame
  2. Change the default to return matrices instead of data frames

The offending place in the code is here:
https://github.com/willtownes/glmpca/blob/master/R/postprocess.R#L86

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions