Files being renamed

[Talbain24]

Hello, the utility is great, thank you, very useful to convert my isos and save space. That said, it seems to arbitrarily rename the output files and that can be a bit annoying.

The utility seems to strip region and language tags from the filename, so if I have "Gears of War (USA, Europe) (En,Fr,De,Es,It,Zh,Ko).iso" as the input file, and I convert it to .zar, the the resulting file will be "Gears of War.zar". The problem is that if I process multiple files where the same title has multiple regions it will overwrite the others, e.g.:

If i process

Gears of War 3 (Spain) (En,Es).iso
Gears of War 3 (World) (En,Fr,Pt,Zh,Ko,Pl,Ru,Cs,Hu).iso

I will end up with

Gears of War 3.zar

The (Spain) variant will be overwritten by the (World) variant.

I can circumvent this issue by processing one by one, but it's slower and then I have to manually rename each file by hand, defeating the purpose of batch processing files.

Edit: Disc number tags are also being ignored, so multiple disc games are also affected, you end up with only one disc converted.

Surely there is a reason behind this behavior but, at least an option to keep filenames as they are would be nice.

Thank you again for your work!

[wiredopposite]

Okay does it do the same thing when converting with "Offline Mode" ticked? That should take the name from the file instead of getting it from the internet, either way I'll fix that in the next update.

[Talbain24]

Okay does it do the same thing when converting with "Offline Mode" ticked? That should take the name from the file instead of getting it from the internet, either way I'll fix that in the next update.

On the first try it did that, so I figured "maybe it's the online mode retrieving the game names" so ticked the offline mode, but the results were the same. So I closed and opened the app again, just in case the names were in cache or something, ticked the offline mode before processing, but it behave the same way, files were being overwritten anyway.

[hifihedgehog]

@wiredopposite, as @Talbain24 notes in the post directly above mine here, running in Offline Mode does not fix the issue of the program stripping away the parenthetical ROM information.

For example, 2010 FIFA World Cup South Africa (USA, Asia) (En,Fr,Es).iso becomes 2010 FIFA World Cup South Africa.zar.

[hifihedgehog]

@wiredopposite @Talbain24

This is what is causing the issue. There is a function call to clean the title in offline mode that by regular expression/regex removes all pairs of parentheses in the filename. Please, either remove this or add a toggleable setting for this in your GUI program and command line executable. Thanks!

XGDTool/src/TitleHelper/TitleHelper.cpp

Line 104 in a372d7a

clean_title_name(title_name_);

XGDTool/src/TitleHelper/TitleHelper.cpp

Lines 466 to 473 in a372d7a

	void TitleHelper::clean_title_name(std::string& title)
	{
	std::regex parenr_regex(R"(\(.*?\))");
	std::string result = std::regex_replace(title, parenr_regex, "");
	std::regex space_regex(R"(\s{2,})");
	result = std::regex_replace(result, space_regex, " ");
	title = result;
	}

[hifihedgehog]

Update:

You'll also need to remove these lines (I may have deleted more than necessary but they aren't used for XAR) here which also truncate the file name:

XGDTool/src/TitleHelper/TitleHelper.cpp

Lines 98 to 102 in a372d7a

	size_t t_pos = min(title_name_.find(" ("), title_name_.find(" ["));
	if (t_pos != std::string::npos)
	{
	title_name_ = title_name_.substr(0, t_pos);
	}

XGDTool/src/TitleHelper/TitleHelper.cpp

Lines 111 to 118 in a372d7a

	unique_name_ = create_unique_name(exe_tool.xex_cert());
	folder_name_ = folder_name_.substr(0, 42);
	god_folder_name_ = god_folder_name_.substr(0, 31) + " [" + StringUtils::uint32_to_hex_string(exe_tool.title_id()) + "]";
	iso_name_ = iso_name_.substr(0, 36);
	if (utf16_title_name_.size() > 40) {
	utf16_title_name_.resize(40);
	}

[hifihedgehog]

@Talbain24, here is a fixed build implementing the above.

https://file.io/pGjHq5BAfvoZ

Do not use the above. #2 shows that XGDTool is currently unreliable and unsafe for archival. Use this instead:

https://github.com/hifihedgehog/The-World-s-Easiest-.ZIP-Xbox-360-.ISO-to-.ZAR-Batch-PowerShell-Applet