Corrupts File or Folder Structure

[hifihedgehog]

See title.
If I use XGDTool to convert Sonic Unleashed from ISO to ZAR and attempt to play Windmill Isle Daytime Act 2, I get the resulting error in Xenia Canary:

If I use isoextract and Xenia Canary to extract and then pack the exact same ISO to ZAR, I never get this error.

I am extracting the non-working ZAR and comparing the contents with the working ZAR's extract contents to try to determine where the corruption occurred in XGDTool. My hunch is file naming is likely getting modified by XGDTool.

[hifihedgehog]

I would caution anyone to not use XGDTool unless you keep your original ISOs handy as I can confirm it breaks games.

[hifihedgehog]

Found the difference with WinMerge. $SystemUpdate is inconsequential. However, XGDTool is skipping these files in the Sound folder when it does a direct ISO to ZAR conversion of Sonic Unleashed.

[hifihedgehog]

My hunch is ImageExtractor.cpp is the culprit. Without digging too deep, I suspect it has to do with this subroutine:

XGDTool/src/ImageExtractor/ImageExtractor.cpp

Lines 30 to 34 in a372d7a

	if (!StringUtils::safe_string(dir_entry.filename))
	{
	XGDLog(Error) << "Filename contains potentially dangerous characters.\nSkipping: " << dir_entry.filename << "\n";
	continue;
	}

Tried compiling. Omitting this didn't fix the issue. For now, I recommend using the below:

hifihedgehog/The-World-s-Easiest-.ZIP-Xbox-360-.ISO-to-.ZAR-Batch-PowerShell-Applet

[wiredopposite]

That's a security thing, in case someone's made a malicious ISO with unsafe strings in filenames, it just omits the file altogether if it sees anything weird. Those filenames don't have any of the things that would get it flagged as dangerous so I'm going to run some tests on this, I probably need to change how the program writes the directory structure to ZAR if it's just missing things.