Skip to content

WA-NEW-006: Fix Payment#complete? to treat zero authorization as incomplete #629

@jhill

Description

@jhill

Goal: Make complete? return false when payment.credit_card.amount is zero (or otherwise non-authorizing) to satisfy expectations and avoid placing invalid orders.

Symptoms: Workarea::Checkout::Steps::PaymentTest#test_complete? fails because amount = 0 still yields complete? == true.

Verify: bundle exec ruby -Icore/test core/test/models/workarea/checkout/steps/payment_test.rb

Branch: wa-new-006-payment-complete-zero-amount
PR target: next

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions