WA-NEW-013: Unstack early modernization commits (WA-NEW-002..005) into discrete issues/PRs

[kitcommerce]

Problem

PRs #630 (WA-NEW-006) and #631 (WA-NEW-007) are stacked on top of earlier commits (WA-NEW-002..005) that are not tracked as first-class issues/PRs in the current board/workflow. This makes review harder and blocks clean merge sequencing.

Goal

Make review/merge order clean and incremental by extracting WA-NEW-002..005 into their own issues + PRs (targeting next).

Scope

• Identify the commits currently bundled underneath WA-NEW-006: Fix Payment#complete? to treat zero authorization as incomplete #630/WA-NEW-007: Stabilize create_placed_order factory #631:
  • WA-NEW-002 guard callback workers + truncate all Mongoid clients in tests
  • WA-NEW-003 DataFile password randomization test determinism
  • WA-NEW-004 metrics week math across DST
  • WA-NEW-005 remove unsupported use_dis_max from query_string (ES7)
• Create missing tracking issues for each (WA-NEW-002..005) and add to board
• Create PRs for each (or rebase existing branches) so each PR is minimal and reviewable
• Rebase/retarget WA-NEW-006 and WA-NEW-007 PRs onto a next that includes those earlier merges

Acceptance Criteria

• WA-NEW-002..005 each have: (1) issue, (2) PR, (3) board item
• WA-NEW-006: Fix Payment#complete? to treat zero authorization as incomplete #630 and WA-NEW-007: Stabilize create_placed_order factory #631 become minimal (only WA-NEW-006 and WA-NEW-007 changes)
• Merge order is explicit and linear

Notes

• This will also reduce the surface area when CI is restored (WA-NEW-012).

[kitcommerce]

Dispatched to implementer session "workarea-#637-wa-new-013". PRs will target next.

[kitcommerce]

Unstacked the early commits from PRs #630/#631 into discrete issues/PRs (all targeting next).

New issues + PRs (merge order):

1. Fix Elasticsearch index create race in tests #650 / Fix Elasticsearch index create race in tests #651 – Fix Elasticsearch index create race in tests
2. WA-NEW-002: Guard callback workers + truncate all Mongoid clients in tests #642 / WA-NEW-002: Guard callback workers + truncate all Mongoid clients in tests #646 – WA-NEW-002: Guard callback workers + truncate all Mongoid clients in tests
3. WA-NEW-003: Fix DataFile password randomization tests to be deterministic #643 / WA-NEW-003: Fix DataFile password randomization tests to be deterministic #647 – WA-NEW-003: DataFile password randomization tests deterministic
4. WA-NEW-004: Fix metrics week calculations across DST #644 / WA-NEW-004: Fix metrics week calculations across DST #648 – WA-NEW-004: Fix metrics week calculations across DST
5. WA-NEW-005: Remove unsupported use_dis_max from query_string queries (ES7) #645 / WA-NEW-005: Remove unsupported use_dis_max from query_string queries (ES7) #649 – WA-NEW-005: Remove unsupported use_dis_max from query_string queries (ES7)

Then:

• WA-NEW-006: Fix Payment#complete? to treat zero authorization as incomplete #630 has been rewritten to contain only WA-NEW-006 (force-pushed)
• WA-NEW-007: Stabilize create_placed_order factory #631 has been rewritten to contain only WA-NEW-007 (force-pushed)

After the above PRs merge into next, #630/#631 should be ready to merge cleanly with a linear history.

[kitcommerce]

Completed. Unstacked WA-NEW-002..005 into discrete issues/PRs and rewrote PRs #630/#631 to be minimal. New PRs: #646-#649 and #651. See coordinating comment for merge order.