fix: avoid EEXIST on race condition in createDirRecursively and copyFolderRecursiveSync (#154)

Replace custom recursive directory creation with built-in recursive mkdir in
node addon loading

When multiple packaged applications try to start simultaneously, they can
encounter race conditions when creating temporary directories for loading native
node addons. This manifests as an "EEXIST" error when calling `mkdirSync()`.

The issue occurs in the native module loading code path where pkg needs to
extract native addons to a temporary location before they can be loaded via
`process.dlopen()`. The current implementation uses a custom
`createDirRecursively()` function that has a race condition - it checks if a
directory exists and then tries to create it, but another process could create
the directory between the check and creation.

Node.js has built-in support for recursive directory creation via the
`recursive: true` option in `mkdirSync()`. This handles race conditions properly
- if the directory already exists, it will not throw an error. This is exactly
what we need.

Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>

Author: dividedmind

prelude/bootstrap.js

@@ -185,9 +185,7 @@ function copyFolderRecursiveSync(source, target) {
   const targetFolder = path.join(target, path.basename(source));
 
   // Check if target folder needs to be created or integrated
-  if (!fs.existsSync(targetFolder)) {
-    fs.mkdirSync(targetFolder);
-  }
+  fs.mkdirSync(targetFolder, { recursive: true });
 
   // Copy
   if (fs.lstatSync(source).isDirectory()) {
@@ -249,13 +247,6 @@ function copyFolderRecursiveSync(source, target) {
   }
 }
 
-function createDirRecursively(dir) {
-  if (!fs.existsSync(dir)) {
-    createDirRecursively(path.join(dir, '..'));
-    fs.mkdirSync(dir);
-  }
-}
-
 /*
 
 // TODO move to some test
@@ -2218,7 +2209,7 @@ function payloadFileSync(pointer) {
       // Example: /home/john/.cache/pkg/<hash>
       const tmpFolder = path.join(homedir(), '.cache/pkg', hash);
 
-      createDirRecursively(tmpFolder);
+      fs.mkdirSync(tmpFolder, { recursive: true });
 
       // Example: moduleFolder = /snapshot/appname/node_modules/sharp/build/Release
       const parts = moduleFolder.split(path.sep);