Farm: Keep product type from instances#1702
Merged
Conversation
iLLiCiTiT
added
type: bug
iLLiCiTiT
requested review from
64qam,
BigRoy,
LiborBatek,
MilaKudr,
antirotor and
kalisp
BigRoy
reviewed
Feb 13, 2026
jakubjezek001
approved these changes
Feb 13, 2026
github-project-automation
bot
moved this from Review In Progress
to Merge Requested
in PR reviewing
64qam
approved these changes
Feb 13, 2026
iLLiCiTiT
changed the title
Member
|
works in houdini too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Keep product type from instance in
create_skeleton_instance.Additional info
When product base type is being used, it is possible that product type is customized. Unfortunatelly the only way how to find out if product type is customized is that we do compare it to product base type.
This uncovered huge flaw in current situation with product types we have defined un host. Maya is using
"renderlayer"as product base type, 3ds max is using"maxrender"and who knowh what houdini is using. The point being that the create plugins are using product base type "A" but whencreate_skeleton_instanceis used, it is converted to"render".To fully resolve that issue we have to create alternative versions of each function, and alternative versions of farm plugins that operate on different level.
Testing notes:
This change affects all hosts using
create_skeleton_instance. Test farm publishin for all hosts using it.