Skip to content

Remove a line that is clearing the hash fragment in the window URL fo… #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vemonet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove a line that is clearing the hash fragment in the window URL fo… #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,35 @@ yarn add @zazuko/yasgui

## Local development

#### Installing dependencies
### Install dependencies

Run `npm install`.
```sh
npm install
```

#### Running Yasgui locally
### Run Yasgui locally

To develop locally, run `npm run dev`
To develop locally, run:

#### Compiling Yasgui
```sh
npm run dev
```

Run `npm run build`. It'll store the transpiled js/css files in the `build` directory.
### Compiling Yasgui

It'll store the transpiled js/css files in the `build` directory. Run:

```sh
npm run build
```

### Run tests

You'll first need to compile it, then run:

```sh
npm test
```

## License

Expand Down
1 change: 0 additions & 1 deletion packages/yasgui/src/linkUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ var getUrlParams = function (_url?: string) {
//firefox does some decoding if we're using window.location.hash (e.g. the + sign in contentType settings)
//Don't want this. So simply get the hash string ourselves
url.query(url.anchor());
if (urlFromWindow) window.location.hash = ""; //clear hash
Copy link
Member

@ludovicm67 ludovicm67 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and also for the documentation improvements.

I understand the reason why the removal of the hash from the URL could impact some websites, but this was the behavior since years. Changing this would also have unexpected effects for current solutions.

An alternative could be to add an explicit configuration parameter ; by default it keeps the current behavior, and if this new configuration option is set, then that hash clearing could be ignored.

@vemonet do you think it could make sense?
That way we have something that is still behaving the way people expect, and for people having an issue with the current behavior could easily just explicitly tell Yasgui to not remove the hash.

Could you update this PR to integrate that suggestion?

}
return url;
};
Expand Down