Update RepositoryRetriever to catch EdpGithub exception and return false

Author: adamlundrigan

module/Application/src/Application/Service/RepositoryRetriever.php

@@ -46,11 +46,16 @@ public function getUserRepositoryMetadata($user, $module)
      * @param string $user
      * @param array $params
      *
-     * @return RepositoryCollection
+     * @return RepositoryCollection|bool
      */
     public function getUserRepositories($user, $params = [])
     {
-        return $this->githubClient->api('user')->repos($user, $params);
+        try {
+            return $this->githubClient->api('user')->repos($user, $params);
+        }
+        catch (RuntimeException $e) {
+            return false;
+        }
     }
 
     /**
@@ -140,10 +145,15 @@ public function getRepositoryFileMetadata($user, $module, $filePath)
      *
      * @param array $params
      *
-     * @return RepositoryCollection
+     * @return RepositoryCollection|bool
      */
     public function getAuthenticatedUserRepositories($params = [])
     {
-        return $this->githubClient->api('current_user')->repos($params);
+        try {
+            return $this->githubClient->api('current_user')->repos($params);
+        }
+        catch (RuntimeException $e) {
+            return false;
+        }
     }
 }

module/Application/test/ApplicationTest/Service/RepositoryRetrieverTest.php

@@ -45,6 +45,22 @@ public function testCanRetrieveUserRepositories()
         $this->assertEquals(count($payload), $count);
     }
 
+    public function testGetUserRepositoriesReturnsFalseOnRemoteFailure()
+    {
+        $client = $this->getClientMock(
+            new Api\User(),
+            []
+        );
+        $client->expects($this->any())
+               ->method('api')
+               ->willThrowException(new Exception\RuntimeException());
+
+        $service = new RepositoryRetriever($client);
+
+        $repositories = $service->getUserRepositories('foo');
+        $this->assertFalse($repositories);
+    }
+
     public function testCanRetrieveUserRepositoryMetadata()
     {
         $payload = [
@@ -202,6 +218,22 @@ public function testCanRetrieveAuthenticatedUserRepositories()
         $this->assertEquals(count($payload), $count);
     }
 
+    public function testGetAuthenticatedUserRepositoriesReturnsFalseOnRemoteFailure()
+    {
+        $client = $this->getClientMock(
+            new Api\CurrentUser(),
+            []
+        );
+        $client->expects($this->any())
+               ->method('api')
+               ->willThrowException(new Exception\RuntimeException());
+
+        $service = new RepositoryRetriever($client);
+
+        $repositories = $service->getAuthenticatedUserRepositories();
+        $this->assertFalse($repositories);
+    }
+
     public function testRepositoryFileContentFails()
     {
         $clientMock = $this->getMock('EdpGithub\Client');