Fix: Rename config key and service identifier

Author: localheinz

module/Application/config/module.config.php

@@ -6,7 +6,7 @@
 use Psr\Log;
 
 return [
-    'github_repository' => [
+    'project_github_repository' => [
         'owner' => 'zendframework',
         'name'  => 'modules.zendframework.com',
     ],
@@ -97,8 +97,8 @@
     'service_manager' => [
         'factories' => [
             \HTMLPurifier::class => Service\HtmlPurifierFactory::class,
-            'github_repository' => Service\GitHubRepositoryFactory::class,
             Log\LoggerInterface::class => Service\LoggerFactory::class,
+            'project_github_repository' => Service\GitHubRepositoryFactory::class,
             Service\ErrorHandlingService::class => Service\ErrorHandlingServiceFactory::class,
             Service\RepositoryRetriever::class => Service\RepositoryRetrieverFactory::class,
         ],

module/Application/src/Application/Controller/ContributorsControllerFactory.php

@@ -23,7 +23,7 @@ public function createService(ServiceLocatorInterface $controllerManager)
         $repositoryRetriever = $serviceManager->get(Service\RepositoryRetriever::class);
 
         /* @var Entity\Repository $repository */
-        $repository = $serviceManager->get('github_repository');
+        $repository = $serviceManager->get('project_github_repository');
 
         return new ContributorsController(
             $repositoryRetriever,

module/Application/src/Application/Service/GitHubRepositoryFactory.php

@@ -14,7 +14,7 @@ class GitHubRepositoryFactory implements FactoryInterface
      */
     public function createService(ServiceLocatorInterface $serviceLocator)
     {
-        $config = $serviceLocator->get('Config')['github_repository'];
+        $config = $serviceLocator->get('Config')['project_github_repository'];
 
         return new Entity\Repository(
             $config['owner'],

module/Application/src/Application/View/Helper/GitHubRepositoryUrlFactory.php

@@ -20,7 +20,7 @@ public function createService(ServiceLocatorInterface $serviceLocator)
         $serviceManager = $serviceLocator->getServiceLocator();
 
         /* @var Entity\Repository $repository */
-        $repository = $serviceManager->get('github_repository');
+        $repository = $serviceManager->get('project_github_repository');
 
         return new GitHubRepositoryUrl($repository);
     }

module/Application/test/ApplicationTest/Integration/Controller/ContributorsControllerTest.php

@@ -74,7 +74,7 @@ public function testContributorsActionCanBeAccessed()
         $this->getApplicationServiceLocator()
             ->setAllowOverride(true)
             ->setService(
-                'github_repository',
+                'project_github_repository',
                 $repository
             )
             ->setService(

module/Application/test/ApplicationTest/Integration/Service/GitHubRepositoryTest.php

@@ -18,7 +18,7 @@ public function testServiceCanBeRetrieved()
 
         $this->assertInstanceOf(
             Entity\Repository::class,
-            $serviceManager->get('github_repository')
+            $serviceManager->get('project_github_repository')
         );
     }
 }