update unit tests for observer migration script to improve coverage

Author: kingpinXD

pkg/rpc/clients_test.go

@@ -453,6 +453,36 @@ func TestZetacore_GetNodeInfo(t *testing.T) {
 	require.Equal(t, expectedOutput, *resp)
 }
 
+func TestZetacore_GetSyncing(t *testing.T) {
+	ctx := context.Background()
+
+	t.Run("node is syncing", func(t *testing.T) {
+		expectedOutput := cmtservice.GetSyncingResponse{Syncing: true}
+		input := cmtservice.GetSyncingRequest{}
+		method := "/cosmos.base.tendermint.v1beta1.Service/GetSyncing"
+		setupMockServer(t, cmtservice.RegisterServiceServer, method, input, expectedOutput)
+
+		client := setupZetacoreClients(t)
+
+		resp, err := client.GetSyncing(ctx)
+		require.NoError(t, err)
+		require.True(t, resp)
+	})
+
+	t.Run("node is not syncing", func(t *testing.T) {
+		expectedOutput := cmtservice.GetSyncingResponse{Syncing: false}
+		input := cmtservice.GetSyncingRequest{}
+		method := "/cosmos.base.tendermint.v1beta1.Service/GetSyncing"
+		setupMockServer(t, cmtservice.RegisterServiceServer, method, input, expectedOutput)
+
+		client := setupZetacoreClients(t)
+
+		resp, err := client.GetSyncing(ctx)
+		require.NoError(t, err)
+		require.False(t, resp)
+	})
+}
+
 func TestZetacore_GetBaseGasPrice(t *testing.T) {
 	ctx := context.Background()
 

x/observer/migrations/v12/migrate.go

@@ -25,9 +25,7 @@ func MigrateStore(ctx sdk.Context, observerKeeper observerKeeper) error {
 		return err
 	}
 
-	if err := UpdateCrosschainFlags(ctx, observerKeeper); err != nil {
-		return err
-	}
+	UpdateCrosschainFlags(ctx, observerKeeper)
 
 	return nil
 }
@@ -60,16 +58,14 @@ func UpdateChainParams(ctx sdk.Context, observerKeeper observerKeeper) error {
 }
 
 // UpdateCrosschainFlags disables V2 ZETA flows in the crosschain flags.
-func UpdateCrosschainFlags(ctx sdk.Context, observerKeeper observerKeeper) error {
+func UpdateCrosschainFlags(ctx sdk.Context, observerKeeper observerKeeper) {
 	flags, found := observerKeeper.GetCrosschainFlags(ctx)
 	if !found {
 		flags = *types.DefaultCrosschainFlags()
 	}
 
 	flags.IsV2ZetaEnabled = false
 	observerKeeper.SetCrosschainFlags(ctx, flags)
-
-	return nil
 }
 
 // GetGasPriceMultiplierForChain returns the gas price multiplier for the given chain

x/observer/migrations/v12/migrate_test.go

@@ -50,6 +50,51 @@ func TestMigrateStore(t *testing.T) {
 		require.True(t, flags.IsInboundEnabled)
 		require.True(t, flags.IsOutboundEnabled)
 	})
+
+	t.Run("returns error when chain params not found", func(t *testing.T) {
+		// ARRANGE
+		k, ctx, _, _ := keepertest.ObserverKeeper(t)
+
+		// don't set any chain params
+
+		// ACT
+		err := v12.MigrateStore(ctx, *k)
+
+		// ASSERT
+		require.ErrorIs(t, err, types.ErrChainParamsNotFound)
+	})
+
+	t.Run("returns error when chain not found in chain params", func(t *testing.T) {
+		// ARRANGE
+		k, ctx, _, _ := keepertest.ObserverKeeper(t)
+
+		// set chain params with invalid chain ID
+		testChainParams := getTestChainParams()
+		testChainParams.ChainParams[0].ChainId = 999999999
+		k.SetChainParamsList(ctx, testChainParams)
+
+		// ACT
+		err := v12.MigrateStore(ctx, *k)
+
+		// ASSERT
+		require.ErrorIs(t, err, types.ErrSupportedChains)
+	})
+
+	t.Run("returns error when chain params validation fails", func(t *testing.T) {
+		// ARRANGE
+		k, ctx, _, _ := keepertest.ObserverKeeper(t)
+
+		// set chain params with invalid values that will fail validation
+		testChainParams := getTestChainParams()
+		testChainParams.ChainParams[0].InboundTicker = 0
+		k.SetChainParamsList(ctx, testChainParams)
+
+		// ACT
+		err := v12.MigrateStore(ctx, *k)
+
+		// ASSERT
+		require.ErrorIs(t, err, types.ErrInvalidChainParams)
+	})
 }
 
 func TestUpdateChainParams(t *testing.T) {
@@ -146,10 +191,9 @@ func TestUpdateCrosschainFlags(t *testing.T) {
 		})
 
 		// ACT
-		err := v12.UpdateCrosschainFlags(ctx, *k)
+		v12.UpdateCrosschainFlags(ctx, *k)
 
 		// ASSERT
-		require.NoError(t, err)
 		flags, found := k.GetCrosschainFlags(ctx)
 		require.True(t, found)
 		require.False(t, flags.IsV2ZetaEnabled)
@@ -167,10 +211,9 @@ func TestUpdateCrosschainFlags(t *testing.T) {
 		require.False(t, found)
 
 		// ACT
-		err := v12.UpdateCrosschainFlags(ctx, *k)
+		v12.UpdateCrosschainFlags(ctx, *k)
 
 		// ASSERT
-		require.NoError(t, err)
 		flags, found := k.GetCrosschainFlags(ctx)
 		require.True(t, found)
 		require.False(t, flags.IsV2ZetaEnabled)