Incoherent argument type in function 'Zonemaster::Engine::Test/run_one()'

[tgreenx]

When running the Test suite, Zonemaster::Engine::Test will run either:

• the full suite (using run_all_for())
• a specific Test module (using run_module())
• a specific Test Case (using run_one()).

The first two take at least one argument which is a Zonemaster::Engine::Zone object. However, the latter takes an array of Zonemaster::Engine::Zone objects (under the variable @arguments). I don't see why that is. From what I have seen all Test Cases only ever handle one argument (which is a Zonemaster::Engine::Zone object).

It has no sizable effect in practice but this part of the code should probably be harmonized.

[matsduf]

The first two take at least one argument which is a Zonemaster::Engine::Zone object. However, the latter takes an array of Zonemaster::Engine::Zone objects (under the variable @arguments). I don't see why that is. From what I have seen all Test Cases only ever handle one argument (which is a Zonemaster::Engine::Zone object).

Isn't the idea that the third can run an array oif specific test cases?

[tgreenx]

No, run_one() also handles only one Test Case under the variable $test. @arguments is the variable passed to a Test Case, which is always one Zonemaster::Engine::Zone object (except for Syntax01 to Syntax04 where it could also theoretically be a string or a Zonemaster::Engine::DNSName object, but currently that never happens. See #1283).

Plus, using Zonemaster-CLI, when supplied with multiple Test Cases each is run independently and in sequence : https://github.com/zonemaster/zonemaster-cli/blob/bb73df2e6125f3ab202fad384639e604fa03cefa/lib/Zonemaster/CLI.pm#L621-L637

$ zonemaster-cli --show-testcase --test Address/address01 --test Zone/zone03 --level INFO --no-ipv6 --raw zonemaster.net
   0.00 INFO     UNSPECIFIED    GLOBAL_VERSION   version=v4.7.2
   1.23 INFO     ADDRESS01      NO_IP_PRIVATE_NETWORK
   0.00 INFO     UNSPECIFIED    GLOBAL_VERSION   version=v4.7.2
   0.07 INFO     ZONE03         REFRESH_HIGHER_THAN_RETRY   refresh=14400; retry=3600

[matsduf]

Resolved by #1294