From 30aa15066144c6b9ebff53d56a2a1b1f72b9c310 Mon Sep 17 00:00:00 2001 From: GeorgH93 Date: Sun, 27 Dec 2015 01:02:02 +0100 Subject: [PATCH 1/9] Small performance improvements (not finished jet!) --- pom.xml | 2 +- .../bukkit/SnowControl/PlayerListener.java | 9 ++--- .../bukkit/SnowControl/SnowMonitor.java | 38 +++++++++++-------- 3 files changed, 27 insertions(+), 22 deletions(-) diff --git a/pom.xml b/pom.xml index 1d86dd1..3f4da7d 100644 --- a/pom.xml +++ b/pom.xml @@ -3,7 +3,7 @@ 4.0.0 com.zmanww SnowControl - 1.1.1 + 1.1.2-SNAPSHOT jar SnowControl 2013 diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java b/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java index 28ba959..0f66f95 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java @@ -130,8 +130,7 @@ public void onBlockDamage(BlockDamageEvent event) { event.getPlayer().sendMessage("MinSurrounding=" + SnowManager.getMinSurrounding(block, (byte) -1)); event.getPlayer().sendMessage("MaxSurrounding=" + SnowManager.getMaxSurrounding(block, (byte) -1)); event.getPlayer().sendMessage("canSnowBeAdded=" + SnowManager.canSnowBeAdded(block)); - event.getPlayer().sendMessage( - "canSnowBeAddedAbove=" + SnowManager.canSnowBeAdded(block.getRelative(BlockFace.UP))); + event.getPlayer().sendMessage("canSnowBeAddedAbove=" + SnowManager.canSnowBeAdded(block.getRelative(BlockFace.UP))); List snowBlocks = SnowManager.getBlocksToIncreaseUnder(event.getBlock()); for (Block blk : snowBlocks) { @@ -142,10 +141,8 @@ public void onBlockDamage(BlockDamageEvent event) { } else if (event.getItemInHand().getType() == Material.SNOW_BLOCK) { event.getPlayer().sendMessage("Increasing Snow Level"); - boolean canIncrease = false; - if (SnowManager.canSnowBeAdded(block)) { - canIncrease = true; - } else if (SnowManager.canSnowBeAdded(block.getRelative(BlockFace.UP))) { + boolean canIncrease = SnowManager.canSnowBeAdded(block); + if (!canIncrease && SnowManager.canSnowBeAdded(block.getRelative(BlockFace.UP))) { block = block.getRelative(BlockFace.UP); canIncrease = true; } diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/SnowMonitor.java b/src/main/java/com/zmanww/bukkit/SnowControl/SnowMonitor.java index be2c5be..2d7c56d 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/SnowMonitor.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/SnowMonitor.java @@ -35,23 +35,31 @@ public class SnowMonitor extends BukkitRunnable { private SnowControl plugin; private Random rnd = new Random(); - private float chanceToAccumulate, chanceToMelt; + private float chanceToAccumulateChunk = 100, chanceToAccumulateBlock, chanceToMeltChunk = 100, chanceToMeltBlock; + private int blocksPerChunkToAccumulate, blocksPerChunkToMelt, maxChunks = 441, minChunks = 1; private boolean accumulation, melt; public SnowMonitor(SnowControl plugin) { super(); this.plugin = plugin; - chanceToAccumulate = (float) Math.sqrt(Config.getInstance().getChanceToAccumulate()) * 10f / 100f; - chanceToMelt = (float) Math.sqrt(Config.getInstance().getChanceToMelt()) * 10f / 100f; + chanceToAccumulateBlock = (float) Config.getInstance().getChanceToAccumulate() / 100f; //TODO: Change config + chanceToMeltBlock = Config.getInstance().getChanceToMelt() / 100f; //TODO: Change config accumulation = Config.getInstance().isAccumulationEnabled(); melt = Config.getInstance().isMeltingEnabled(); + //TODO: Read configs for: maxChunks, minChunks, chanceToAccumulateChunk, chanceToMeltChunk + + // Calculate stuff, we don't need to do this every time we run our loops + blocksPerChunkToAccumulate = (int) Math.ceil(256 * chanceToAccumulateBlock); + blocksPerChunkToMelt = (int) Math.ceil(256 * chanceToMeltBlock); } private Chunk[] getRandomElements(int count, Chunk... items) { if(count > items.length) count = items.length; + if(count == items.length) + return items; List list = new ArrayList<>(count); Chunk data; while(count > 0) @@ -63,7 +71,9 @@ private Chunk[] getRandomElements(int count, Chunk... items) count--; } } - return list.toArray(new Chunk[count]); + items = list.toArray(new Chunk[count]); + list.clear(); + return items; } private List generateRandom2DPosList(int count) @@ -75,11 +85,13 @@ private List generateRandom2DPosList(int minX, int maxX, int minY, int ma { if(count > (maxX - minX + 1) * (maxY - minY + 1)) count = (maxX - minX + 1) * (maxY - minY + 1); + maxX = maxX - minX + 1; + maxY = maxY - minY + 1; List list = new ArrayList<>(count); Pos2D randPos; while(count > 0) { - randPos = new Pos2D(rnd.nextInt(maxX - minX + 1) + minX, rnd.nextInt(maxY - minY + 1) + minY); + randPos = new Pos2D(rnd.nextInt(maxX) + minX, rnd.nextInt(maxY) + minY); if(!list.contains(randPos)) { list.add(randPos); @@ -128,21 +140,17 @@ public void run() plugin.debugLog("Checking " + chunks.length + " chunks in " + worldName); if(accumulation && world.hasStorm()) { - chunks = getRandomElements((int) Math.ceil(chunks.length * chanceToAccumulate), chunks); // I know it's not perfect, but we have to sacrifice precision for performance + chunks = getRandomElements(Math.min(Math.max((int) Math.ceil(chunks.length * chanceToAccumulateChunk), minChunks), maxChunks), chunks); // I know it's not perfect, but we have to sacrifice precision for performance for(Chunk chunk : chunks) { - List blocks = generateRandom2DPosList((int) Math.ceil(256 * chanceToAccumulate)); // I know it's not perfect, but we have to sacrifice precision for performance + List blocks = generateRandom2DPosList(blocksPerChunkToAccumulate); // I know it's not perfect, but we have to sacrifice precision for performance for(Pos2D pos : blocks) { Block block = SnowManager.getHighestNonAirBlock(pos.getX() + chunk.getX() * 16, pos.getY() + chunk.getZ() * 16, world); if(block.getType() != Material.AIR && SnowManager.canSnowInBiome(block.getBiome())) { - boolean canIncrease = false; - if(SnowManager.canSnowBeAdded(block)) - { - canIncrease = true; - } - else if(SnowManager.canSnowBeAdded(block.getRelative(BlockFace.UP))) + boolean canIncrease = SnowManager.canSnowBeAdded(block); + if(!canIncrease && SnowManager.canSnowBeAdded(block.getRelative(BlockFace.UP))) { block = block.getRelative(BlockFace.UP); canIncrease = true; @@ -161,10 +169,10 @@ else if(SnowManager.canSnowBeAdded(block.getRelative(BlockFace.UP))) } else if(melt && !world.hasStorm()) { - chunks = getRandomElements((int) Math.ceil(chunks.length * chanceToMelt), chunks); // I know it's not perfect, but we have to sacrifice precision for performance + chunks = getRandomElements(Math.min(Math.max((int) Math.ceil(chunks.length * chanceToMeltChunk), minChunks), maxChunks), chunks); // I know it's not perfect, but we have to sacrifice precision for performance for(final org.bukkit.Chunk chunk : chunks) { - List blocks = generateRandom2DPosList((int) Math.ceil(256 * chanceToMelt)); // I know it's not perfect, but we have to sacrifice precision for performance + List blocks = generateRandom2DPosList(blocksPerChunkToMelt); // I know it's not perfect, but we have to sacrifice precision for performance for(Pos2D pos : blocks) { Block block = SnowManager.getHighestNonAirBlock(pos.getX() + chunk.getX() * 16, pos.getY() + chunk.getZ() * 16, world); From c434df9b3578e1ffc12fab985050d9694115b5fd Mon Sep 17 00:00:00 2001 From: GeorgH93 Date: Tue, 29 Dec 2015 23:29:30 +0100 Subject: [PATCH 2/9] Small performance improvements Add new config value --- .../com/zmanww/bukkit/SnowControl/Config.java | 9 ++++--- .../bukkit/SnowControl/SnowControl.java | 15 ++++++++--- .../bukkit/SnowControl/SnowManager.java | 14 ++--------- .../bukkit/SnowControl/SnowMonitor.java | 25 +++++++++---------- src/main/resources/config.yml | 1 + 5 files changed, 33 insertions(+), 31 deletions(-) diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/Config.java b/src/main/java/com/zmanww/bukkit/SnowControl/Config.java index 6a048fa..17c966c 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/Config.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/Config.java @@ -59,9 +59,8 @@ public static Config getInstance() { public void reload() { plugin.reloadConfig(); // Force reload instance = null;// Force all objects to reload. - - // restart the Monitor - plugin.startScheduler(); + plugin.load(); + plugin.startScheduler(); // restart the Monitor } private void loadKeys() { @@ -201,4 +200,8 @@ public int getMinLightLevel() { return plugin.getConfig().getInt("SnowFall.MinLightLevelToMelt", 12); } + public int getMaxChunksPerCheck() + { + return Math.min(plugin.getConfig().getInt("SnowFall.MaxChunksPerWorldAndCheck", 441), 1); + } } diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/SnowControl.java b/src/main/java/com/zmanww/bukkit/SnowControl/SnowControl.java index b4654fd..0a0f36a 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/SnowControl.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/SnowControl.java @@ -41,10 +41,13 @@ public class SnowControl extends JavaPlugin implements Listener { public static Map pendingCommand = new HashMap<>(); + private boolean debug = false; + private SnowMonitor snowMonitor; public void onEnable() { plugin = this; + load(); getServer().getPluginManager().registerEvents(playerListener, this); getServer().getPluginManager().registerEvents(worldListener, this); getCommand("snowcontrol").setExecutor(new CommandManager()); @@ -63,6 +66,11 @@ public void onEnable() { } } + public void load() + { + debug = Config.getInstance().debugEnabled(); + } + public void startScheduler() { if(snowMonitor != null) @@ -82,10 +90,11 @@ public void onDisable() { this.saveConfig(); } - public void debugLog(String string) { - if (Config.getInstance().debugEnabled()) { + public void debugLog(String string) + { + if (debug) + { this.getLogger().log(Level.INFO, " " + string); } - } } \ No newline at end of file diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/SnowManager.java b/src/main/java/com/zmanww/bukkit/SnowControl/SnowManager.java index c13ca7c..16e0988 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/SnowManager.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/SnowManager.java @@ -85,20 +85,10 @@ public static int getSnowDepth(Block block) { } public static boolean canSnowInBiome(Biome biome) { - if (biome.name().toUpperCase().contains("ICE_")) { - return true; - } - if (biome.name().toUpperCase().contains("COLD_")) { - return true; - } - if (biome.name().toUpperCase().contains("FROZEN_")) { - return true; - } - return false; + return biome.name().toUpperCase().contains("ICE_") || biome.name().toUpperCase().contains("COLD_") || biome.name().toUpperCase().contains("FROZEN_"); } - public static void decreaseSnowLevel(Location loc) { - Block block = loc.getBlock(); + public static void decreaseSnowLevel(Block block) { if (block.getType() == Material.SNOW || block.getType() == Material.SNOW_BLOCK) { byte blkData = getSnowValue(block); if (blkData >= getMinSurrounding(block, (byte) 0) && blkData > getMaxSurrounding(block, (byte) 0, true) - 2) { diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/SnowMonitor.java b/src/main/java/com/zmanww/bukkit/SnowControl/SnowMonitor.java index 2d7c56d..7011d4a 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/SnowMonitor.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/SnowMonitor.java @@ -35,19 +35,20 @@ public class SnowMonitor extends BukkitRunnable { private SnowControl plugin; private Random rnd = new Random(); - private float chanceToAccumulateChunk = 100, chanceToAccumulateBlock, chanceToMeltChunk = 100, chanceToMeltBlock; - private int blocksPerChunkToAccumulate, blocksPerChunkToMelt, maxChunks = 441, minChunks = 1; + private float chanceToAccumulateBlock, chanceToMeltBlock; + private int blocksPerChunkToAccumulate, blocksPerChunkToMelt, maxChunks, minLightLevel; private boolean accumulation, melt; public SnowMonitor(SnowControl plugin) { super(); this.plugin = plugin; - chanceToAccumulateBlock = (float) Config.getInstance().getChanceToAccumulate() / 100f; //TODO: Change config - chanceToMeltBlock = Config.getInstance().getChanceToMelt() / 100f; //TODO: Change config + chanceToAccumulateBlock = Config.getInstance().getChanceToAccumulate() / 100f; + chanceToMeltBlock = Config.getInstance().getChanceToMelt() / 100f; accumulation = Config.getInstance().isAccumulationEnabled(); melt = Config.getInstance().isMeltingEnabled(); - //TODO: Read configs for: maxChunks, minChunks, chanceToAccumulateChunk, chanceToMeltChunk + maxChunks = Config.getInstance().getMaxChunksPerCheck(); + minLightLevel = Config.getInstance().getMinLightLevel(); // Calculate stuff, we don't need to do this every time we run our loops blocksPerChunkToAccumulate = (int) Math.ceil(256 * chanceToAccumulateBlock); @@ -134,16 +135,15 @@ public void run() for(String worldName : Config.getInstance().enabledWorlds) { World world = plugin.getServer().getWorld(worldName); - if(world == null) - continue; + if(world == null || !((accumulation && world.hasStorm()) || (melt && !world.hasStorm()))) continue; Chunk[] chunks = world.getLoadedChunks(); plugin.debugLog("Checking " + chunks.length + " chunks in " + worldName); + chunks = getRandomElements(Math.min(chunks.length, maxChunks), chunks); if(accumulation && world.hasStorm()) { - chunks = getRandomElements(Math.min(Math.max((int) Math.ceil(chunks.length * chanceToAccumulateChunk), minChunks), maxChunks), chunks); // I know it's not perfect, but we have to sacrifice precision for performance for(Chunk chunk : chunks) { - List blocks = generateRandom2DPosList(blocksPerChunkToAccumulate); // I know it's not perfect, but we have to sacrifice precision for performance + List blocks = generateRandom2DPosList(blocksPerChunkToAccumulate); for(Pos2D pos : blocks) { Block block = SnowManager.getHighestNonAirBlock(pos.getX() + chunk.getX() * 16, pos.getY() + chunk.getZ() * 16, world); @@ -169,10 +169,9 @@ public void run() } else if(melt && !world.hasStorm()) { - chunks = getRandomElements(Math.min(Math.max((int) Math.ceil(chunks.length * chanceToMeltChunk), minChunks), maxChunks), chunks); // I know it's not perfect, but we have to sacrifice precision for performance for(final org.bukkit.Chunk chunk : chunks) { - List blocks = generateRandom2DPosList(blocksPerChunkToMelt); // I know it's not perfect, but we have to sacrifice precision for performance + List blocks = generateRandom2DPosList(blocksPerChunkToMelt); for(Pos2D pos : blocks) { Block block = SnowManager.getHighestNonAirBlock(pos.getX() + chunk.getX() * 16, pos.getY() + chunk.getZ() * 16, world); @@ -193,9 +192,9 @@ else if(melt && !world.hasStorm()) //noinspection deprecation blk.setData((byte) 7); } - if(blk.getType() == Material.SNOW && blk.getLightFromSky() >= Config.getInstance().getMinLightLevel()) + if(blk.getType() == Material.SNOW && blk.getLightFromSky() >= minLightLevel) { - SnowManager.decreaseSnowLevel(new Location(world, blk.getX(), blk.getY(), blk.getZ())); // Melt it down + SnowManager.decreaseSnowLevel(blk); // Melt it down } } } diff --git a/src/main/resources/config.yml b/src/main/resources/config.yml index 74ffdc1..4941bb9 100644 --- a/src/main/resources/config.yml +++ b/src/main/resources/config.yml @@ -9,6 +9,7 @@ SnowFall: #this is only in biomes where snow falls naturally CheckEvery: 10 #number in seconds + MaxChunksPerWorldAndCheck: 441 #max number of chunks to check per world every check AccumulationEnabled: true AccumulationChance: 1 #percent 0-100 MaxAccumulationDefault: 7 # number of 'layers' of snow From 6165d846df5e7b578a733c10d64801336cdd6ea7 Mon Sep 17 00:00:00 2001 From: GeorgH93 Date: Wed, 30 Dec 2015 15:18:55 +0100 Subject: [PATCH 3/9] Bugfix --- .../java/com/zmanww/bukkit/SnowControl/PlayerListener.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java b/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java index 0f66f95..3fbb07e 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java @@ -169,8 +169,7 @@ public void onBlockDamage(BlockDamageEvent event) { } if (blk.getLightFromSky() >= 12) { // Melt it down - SnowManager.decreaseSnowLevel(new Location(event.getBlock().getWorld(), blk.getX(), blk.getY(), - blk.getZ())); + SnowManager.decreaseSnowLevel(blk); } } event.getPlayer().sendMessage("**"); From 1797e0c81b131f4ceb6fa2e4e5410e328703ef30 Mon Sep 17 00:00:00 2001 From: GeorgH93 Date: Sat, 9 Jan 2016 20:37:32 +0100 Subject: [PATCH 4/9] Bugfix - Ignored outcome of the event --- .../java/com/zmanww/bukkit/SnowControl/PlayerListener.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java b/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java index 3fbb07e..0cd7e01 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/PlayerListener.java @@ -26,6 +26,7 @@ import org.bukkit.block.Block; import org.bukkit.block.BlockFace; import org.bukkit.event.EventHandler; +import org.bukkit.event.EventPriority; import org.bukkit.event.Listener; import org.bukkit.event.block.BlockBreakEvent; import org.bukkit.event.block.BlockDamageEvent; @@ -43,7 +44,7 @@ public PlayerListener(SnowControl instance) { plugin = instance; } - @EventHandler() + @EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true) public void blockBreak(BlockBreakEvent event) { Block block = event.getBlock(); if (block.getType() == Material.ICE) { From 4a3776840e0098f17d5f9aeaa28c02a323ad3f90 Mon Sep 17 00:00:00 2001 From: GeorgH93 Date: Thu, 3 Mar 2016 01:56:35 +0100 Subject: [PATCH 5/9] Update pom.xml --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 3f4da7d..82afa35 100644 --- a/pom.xml +++ b/pom.xml @@ -3,7 +3,7 @@ 4.0.0 com.zmanww SnowControl - 1.1.2-SNAPSHOT + 1.1.2 jar SnowControl 2013 From 9c98cf044937ae145f20467cabf5d29a892b38f1 Mon Sep 17 00:00:00 2001 From: GeorgH93 Date: Sat, 23 Jun 2018 00:07:00 +0200 Subject: [PATCH 6/9] Add support for TAIGA_COLD and MUTATED_TAIGA_COLD biomes --- pom.xml | 70 ++++--------------- .../bukkit/SnowControl/SnowControl.java | 25 ++----- .../bukkit/SnowControl/SnowManager.java | 12 +--- 3 files changed, 24 insertions(+), 83 deletions(-) diff --git a/pom.xml b/pom.xml index 82afa35..3f24f30 100644 --- a/pom.xml +++ b/pom.xml @@ -3,12 +3,25 @@ 4.0.0 com.zmanww SnowControl - 1.1.2 + 1.1.3 jar SnowControl 2013 https://github.com/zwollner/SnowControl + + UTF-8 + + + + + org.bukkit + bukkit + 1.12-R0.1-SNAPSHOT + provided + + + SnowControl clean install @@ -27,7 +40,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.0 + 3.1 1.7 1.7 @@ -67,7 +80,6 @@ com.zmanww.* - org.mcstats.*:* @@ -82,56 +94,4 @@ - - - UTF-8 - - - - - Plugin Metrics - http://repo.mcstats.org/content/repositories/public - - - Spigot Public - https://hub.spigotmc.org/nexus/content/groups/public - - - - - - - org.bukkit - bukkit - - - junit - junit - test - - - org.mcstats.bukkit - metrics - compile - - - - - - org.bukkit - bukkit - 1.8.8-R0.1-SNAPSHOT - - - org.mcstats.bukkit - metrics - LATEST - - - junit - junit - LATEST - - - diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/SnowControl.java b/src/main/java/com/zmanww/bukkit/SnowControl/SnowControl.java index 0a0f36a..eeb10b5 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/SnowControl.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/SnowControl.java @@ -19,17 +19,16 @@ */ package com.zmanww.bukkit.SnowControl; -import java.io.IOException; -import java.util.HashMap; -import java.util.Map; -import java.util.logging.Level; - import org.bukkit.entity.Player; import org.bukkit.event.Listener; import org.bukkit.plugin.java.JavaPlugin; -import org.mcstats.Metrics; -public class SnowControl extends JavaPlugin implements Listener { +import java.util.HashMap; +import java.util.Map; +import java.util.logging.Level; + +public class SnowControl extends JavaPlugin implements Listener +{ public static SnowControl plugin; private final PlayerListener playerListener = new PlayerListener(this); @@ -52,18 +51,6 @@ public void onEnable() { getServer().getPluginManager().registerEvents(worldListener, this); getCommand("snowcontrol").setExecutor(new CommandManager()); startScheduler(); - if(Config.getInstance().isMeltingEnabled()) - { - try - { - Metrics metrics = new Metrics(this); - metrics.start(); - } - catch(IOException e) - { - // Failed to submit the stats :-( - } - } } public void load() diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/SnowManager.java b/src/main/java/com/zmanww/bukkit/SnowControl/SnowManager.java index 16e0988..06515a1 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/SnowManager.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/SnowManager.java @@ -24,7 +24,6 @@ import java.util.List; import java.util.Random; -import org.bukkit.Location; import org.bukkit.Material; import org.bukkit.World; import org.bukkit.block.Biome; @@ -85,7 +84,7 @@ public static int getSnowDepth(Block block) { } public static boolean canSnowInBiome(Biome biome) { - return biome.name().toUpperCase().contains("ICE_") || biome.name().toUpperCase().contains("COLD_") || biome.name().toUpperCase().contains("FROZEN_"); + return biome.name().contains("ICE_") || biome.name().contains("COLD_") || biome.name().contains("_COLD") || biome.name().contains("FROZEN_"); } public static void decreaseSnowLevel(Block block) { @@ -242,10 +241,7 @@ public static boolean canAccumulateOn(final Block block) { // This is essentially a full block return true; } - if (Config.getInstance().canAccumulateOn.contains(block.getType())) { - return true; - } - return false; + return Config.getInstance().canAccumulateOn.contains(block.getType()); } public static boolean canSnowBeAdded(Block block) { @@ -253,9 +249,7 @@ public static boolean canSnowBeAdded(Block block) { return true; } if (canAccumulateOn(block.getRelative(BlockFace.DOWN))) { - if (Config.getInstance().canReplace.contains(block.getType())) { - return true; - } + return Config.getInstance().canReplace.contains(block.getType()); } return false; } From 1b0991995c74bdd41bb740837e1e91247a845cc8 Mon Sep 17 00:00:00 2001 From: GeorgH93 Date: Sat, 23 Jun 2018 00:15:18 +0200 Subject: [PATCH 7/9] Move to openjdk7, travis doesn't support oraclejdk7 any more --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 6478810..aaf9818 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,7 @@ sudo: false language: java -jdk: oraclejdk7 +jdk: openjdk7 cache: directories: From b7467fc97fc21982cce647bd9f027a8346107cab Mon Sep 17 00:00:00 2001 From: GeorgH93 Date: Sat, 23 Jun 2018 00:19:23 +0200 Subject: [PATCH 8/9] Add missing repository for bukkit dependency --- pom.xml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pom.xml b/pom.xml index 3f24f30..831d1b3 100644 --- a/pom.xml +++ b/pom.xml @@ -13,6 +13,13 @@ UTF-8 + + + spigot-repo + https://hub.spigotmc.org/nexus/content/groups/public/ + + + org.bukkit From f179ab6f8904c534326e1249b6a34bcede74d665 Mon Sep 17 00:00:00 2001 From: GeorgH93 Date: Sat, 23 Jun 2018 00:35:29 +0200 Subject: [PATCH 9/9] Remove remaining references to the metrics code. The mcstats.org service is offline for a long time now and the metrics code has already been removed. --- README.md | 8 -------- src/main/java/com/zmanww/bukkit/SnowControl/Config.java | 5 ----- src/main/resources/config.yml | 4 +--- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/README.md b/README.md index 8610e65..053ba13 100644 --- a/README.md +++ b/README.md @@ -122,11 +122,3 @@ SnowFall: #this is only in biomes where snow falls naturally * Make deeper snow slow down players and/or mobs. * Create custom snow related recipes (ideas welcome) * Enable for snow on mountains not in a snowy biome - -## -*This plugin utilizes Hidendra's plugin metrics system, which means some anonymous information will be collected and sent to mcstats.org. -This allows me to track how many servers are actually running the plugin, and the larger user base I have the more likely I am to add features. -If you wish to opt out of this service, it can be done by editing plugins/Plugin Metrics/config.yml* - - -## diff --git a/src/main/java/com/zmanww/bukkit/SnowControl/Config.java b/src/main/java/com/zmanww/bukkit/SnowControl/Config.java index 17c966c..502b397 100644 --- a/src/main/java/com/zmanww/bukkit/SnowControl/Config.java +++ b/src/main/java/com/zmanww/bukkit/SnowControl/Config.java @@ -151,11 +151,6 @@ public boolean debugEnabled() { return plugin.getConfig().getBoolean("debug", false); } - public boolean isMetricsEnabled() - { - return plugin.getConfig().getBoolean("Metrics", true); - } - public boolean isAccumulationEnabled() { return plugin.getConfig().getBoolean("SnowFall.AccumulationEnabled", true); } diff --git a/src/main/resources/config.yml b/src/main/resources/config.yml index 4941bb9..f696f5c 100644 --- a/src/main/resources/config.yml +++ b/src/main/resources/config.yml @@ -61,6 +61,4 @@ SnowFall: #this is only in biomes where snow falls naturally - SOIL - STONE - WOOD - - WOOL -# Please don't turn it off -Metrics: true \ No newline at end of file + - WOOL \ No newline at end of file