Skip to content

Conversation

@Kolezhniuk
Copy link
Collaborator

refactor: enhance circuit validator type definition for better clarity and maintainability

feat: add new error constant for unknown proving parameters

refactor: update ZKPPacker to support dynamic proving and verification parameters

refactor: modify types for dynamic proving and verification parameters in packer types

test: update auth tests to use new proving method structure

test: adjust credential proposal tests to align with new proving method implementation

test: revise encrypted issuance response tests to utilize updated proving method

test: modify fetch tests to incorporate new proving method structure

test: update payment request handler tests to reflect changes in proving method

test: adjust revocation status tests to use new proving method structure

test: refactor helper functions to accommodate dynamic proving and verification parameters

test: enhance proving method mock to support new circuit structure

test: update zkp tests to reflect changes in protocol message type constants

refactor: enhance circuit validator type definition for better clarity and maintainability

feat: add new error constant for unknown proving parameters

refactor: update ZKPPacker to support dynamic proving and verification parameters

refactor: modify types for dynamic proving and verification parameters in packer types

test: update auth tests to use new proving method structure

test: adjust credential proposal tests to align with new proving method implementation

test: revise encrypted issuance response tests to utilize updated proving method

test: modify fetch tests to incorporate new proving method structure

test: update payment request handler tests to reflect changes in proving method

test: adjust revocation status tests to use new proving method structure

test: refactor helper functions to accommodate dynamic proving and verification parameters

test: enhance proving method mock to support new circuit structure

test: update zkp tests to reflect changes in protocol message type constants
@Kolezhniuk Kolezhniuk changed the title chore: update js-jwz dependency to version 1.13.0 Refactor proving method to support dynamic circuits Dec 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the proving method implementation to support dynamic circuits. The main changes involve restructuring how proving and verification parameters are handled to accommodate multiple circuit IDs dynamically.

Key Changes:

  • Refactored ZKPPacker to support dynamic proving and verification parameters that can handle multiple circuits
  • Updated types to introduce DynamicProvingParams and DynamicVerificationParams structures
  • Modified test helper functions to work with the new ProvingMethod instances instead of CircuitId
  • Extracted CircuitValidatorItem type for better type definition clarity

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/iden3comm/zkp.test.ts Updated imports to use PROTOCOL_CONSTANTS namespace for message type constants
tests/iden3comm/mock/proving.ts Added supportedCircuits getter to mock proving method implementation
tests/helpers.ts Refactored helper functions to accept ProvingMethod instances and create dynamic parameter structures
tests/handlers/*.test.ts Updated all handler tests to pass provingMethod instances instead of circuitId
src/iden3comm/types/packer.ts Added new types DynamicVerificationParams and DynamicProvingParams
src/iden3comm/packers/zkp.ts Refactored to support both legacy and new dynamic parameter structures
src/circuits/validator.ts Extracted CircuitValidatorItem type for improved type definition
src/iden3comm/errors.ts Added new error constant ErrNoProvingParams
package.json Updated @iden3/js-jwz dependency from 1.12.2 to 1.13.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants