Skip to content

Conversation

@e1Ru1o
Copy link
Contributor

@e1Ru1o e1Ru1o commented Jan 19, 2026

Ekubo action modification to support the newly released V3

Relevant changes to discuss:

  1. Some Ekubo tests checks were changed from strict equality to comparisons because there is not enough liquidity to fill the swap so the entire amount of the test is not used
  2. Duplicated Take lib to have a version that calls the selector in the compact way Ekubo V3 expects it. I can revisit this to see if there is a better way than duplicating it.
  3. FROM is now etched to empty code in Ekubo test because in the Ekubo block the address has a delegated implementation. Might be worth etching and making it persistent the moment it is set instead of case by case when needed in a test.
  4. Extension test moved from USDC<>WETH to USDT<>WETH because I did not find a pool with an extension accepting the format we were using for USDC<>WETH

@e1Ru1o e1Ru1o requested a review from duncancmt January 19, 2026 23:21
@e1Ru1o e1Ru1o self-assigned this Jan 19, 2026
@immunefi-magnus
Copy link

🛡️ Immunefi PR Reviews

We noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below:

🔗 Send this PR in for review

Once submitted, we'll take care of assigning a reviewer and follow up here.

Copy link
Collaborator

@duncancmt duncancmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ekubo is only available on chains with clz. Please make appropriate changes to remove it from chains that are not on the Osaka hardfork (all chains except Ethereum). Consider leaving those chains on EkuboV2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants