Execute with permit entrypoint #477
Open
+489
−432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
duncancmt
approved these changes
Jan 24, 2026
| function RFQ_VIP( | ||
| address recipient, | ||
| ISignatureTransfer.PermitTransferFrom memory takerPermit, | ||
| ISignatureTransfer.PermitTransferFrom memory makerPermit, |
Collaborator
There was a problem hiding this comment.
Can you document the constraint that the permit must be the 2nd argument for all VIP actions somewhere in this file?
Collaborator
There was a problem hiding this comment.
upon further reflection, I wonder if it's possible to enforce this in CI by reviewing the artifact produced by compiling the interface
Contributor
Author
There was a problem hiding this comment.
Done in a separate PR (#486) so this one can be merged independently of that script
Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com>
…the zid offset consistent with execute entrypoint
duncancmt
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.